Closed Bug 1063786 Opened 10 years ago Closed 10 years ago

Support nested sprite definitions

Categories

(Firefox Graveyard :: Shumway, defect)

Product:
Firefox Graveyard
Component:
Shumway
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tschneider, Assigned: tschneider)

References

(
URL
)

Details

No description provided.
Assignee: nobody → schneider
Please add the URL to the SWF that led you to file this bug report. I'm guess it was SWF mill.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reverted by https://github.com/mozilla/shumway/pull/1705 due to regression
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I opened a PR with a different solution for this: https://github.com/mozilla/shumway/pull/1716 Yury, can you say if that resolves the regression you saw? Tobias, what do you think of this? I think it should fully work, but I might very well be overlooking something.
Status: REOPENED → NEW
Flags: needinfo?(ydelendik)
Flags: needinfo?(schneider)
(In reply to Till Schneidereit [:till] from comment #4) > I opened a PR with a different solution for this: > https://github.com/mozilla/shumway/pull/1716 > > Yury, can you say if that resolves the regression you saw? > Reftests looks fine, so there is no such regression.
Flags: needinfo?(ydelendik)
Looks pretty fine to me (and much better than my solution). Giving green lights for merging.
Merged as a0053bfe0029145eafbdc4c97f81b0da2b1f0e94. Thanks for the review.
Status: NEW → RESOLVED
Closed: 10 years ago → 10 years ago
Flags: needinfo?(schneider)
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.