Closed Bug 1063789 Opened 10 years ago Closed 10 years ago

[Rocketbar][Places] Performance regression when launching apps

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S4 (12sep)
Tracking Flags:
Tracking Status
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: kgrandon, Assigned: daleharvey)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 1 obsolete file)

Pull request v2
(deleted), text/x-github-pull-request
kgrandon
: review+
bajaj
: approval-gaia-v2.1+
Details
As reported in bug 1041618 comment 9, enabling places has a launch impact on applications. We should do everything we can to not impact launch time, and since we're not surfacing app results in 2.1, we should probably remove them at a minimum.
Blocks: 1059349
Attached file Github pull request (obsolete) (deleted) —
Hey Dale - since we're not surfacing these today, I think this is the safest approach. What do you think?
Attachment #8485236 - Flags: review?(dale)
Comment on attachment 8485236 [details] Github pull request Yup this makes sense to me
Attachment #8485236 - Flags: review?(dale) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/218a444d75f71cad7a86a0307e2b0ae8491a0660
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8485236 [details] Github pull request [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Rocketbar feature work. [User impact] if declined: Users will have slower phones. [Testing completed]: Manual testing. [Risk to taking this patch] (and alternatives if risky): Low risk, isolated to a single file/feature. [String changes made]: No.
Attachment #8485236 - Flags: approval-gaia-v2.1?(bbajaj)
Comment on attachment 8485236 [details] Github pull request Clearing for now.
Attachment #8485236 - Flags: approval-gaia-v2.1?(bbajaj)
Backing out for unit test failures =( https://github.com/mozilla-b2g/gaia/commit/de38033fddf2c332eab1068ae42eccdcbb133312
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
If its ok I will steal this and fix the tests The fix is also needed for https://bugzilla.mozilla.org/show_bug.cgi?id=1063685
Assignee: kgrandon → dale
(In reply to Dale Harvey (:daleharvey) from comment #8) > Re pushed to try > https://tbpl.mozilla.org/ > ?rev=0cd269cbc0d888f30131d690d9c063bff2ee886a&tree=Gaia-Try Funny, before I slept last night I also pushed this again, and updated the tests. Looks like we both got green :-p Sorry for not updating, and thank you for pushing as well. https://github.com/mozilla-b2g/gaia/pull/23792
Attached file Pull request v2 (deleted) —
Carrying R+ from previous.
Attachment #8485236 - Attachment is obsolete: true
Attachment #8485749 - Flags: review+
In master: https://github.com/mozilla-b2g/gaia/commit/5eb3cb2f2d9167bc5e9b21b2fb5f63f7545cfda0
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment on attachment 8485749 [details] Pull request v2 Same as comment 4. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Rocketbar feature work. [User impact] if declined: Users will have slower phones. [Testing completed]: Manual testing. [Risk to taking this patch] (and alternatives if risky): Low risk, isolated to a single file/feature. [String changes made]: No.
Attachment #8485749 - Flags: approval-gaia-v2.1?(bbajaj)
Attachment #8485749 - Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: