Nathan Reporter
	Description • 23 years ago

With build between 10/19 and 10/23:
1) Create a new blank page in composer.
2) Go to HTML source view.
3) Put some text in the body.
4) Go to Normal view.
5) Attempt to delete some text.

Expected results: Text is deletable.

Actual results: Document behaves as if it is empty.

Pressing CTRL+A selects nothing. If you type something in normal mode,
everything works as expected--additional changes in HTML view are edittable in
normal view.

Perhaps this is a regression from fix to bug 93088. Works fine with 10/19 build.

	Jean-Francois Ducarroz
	Comment 1 • 23 years ago

resaaign to right component

	michael wendell
	Comment 2 • 23 years ago

Confirming bug on trunk build 20011023.  This problem is not reproducible on my
20011022 branch build.  

	kinmoz Assignee
	Comment 3 • 23 years ago

I can't reproduce this in my 11/05/01 Mozilla Win32 Debug build. Sujay, can you 
try this out in your build? If you don't see it, let's close this out as a 
WORKSFORME.

Nathan, is there is some specific text you are typing in? Are you adding plain 
text or are you adding HTML tags too? I just switch to the HTML source editing 
pane, added "This is a test." before the <br> that was there and switched back 
to normal mode, and was able to edit it.

	Nathan Reporter
	Comment 4 • 23 years ago

I am just adding plain text, such as your example. I still observe the bug with 
build 2001110503 win32.

	sujay
	Comment 5 • 23 years ago

I can reproduce this in 11/2 trunk and 11/6 trunk build.

	kinmoz Assignee
	Comment 7 • 23 years ago

The problem was that LoadHTML() wasn't clearing out mBogusNode in the rules 
code, so certain operations like DeleteSelection(), SelectAll(), etc thought 
that there was nothing to do because DocumentIsEmpty() was returning true since 
mBogusNode was not null.

Joe, I took a shortcut in Patch Rev 1, and just removed the bogus node when the 
action was kOpHTMLLoad inside of AfterEditInner() ... would you rather that we 
add/call a new WillLoadHTML() method that does this, and add a stub 
DidLoadHTML() method?

	Charles Manske
	Comment 8 • 23 years ago

*** Bug 107753 has been marked as a duplicate of this bug. ***

	kinmoz Assignee
	Comment 11 • 23 years ago

jfrancis - I just attatched a new patch that removes the mBogusNode via the
Will/DidDoAction() mechanism. If it's ok, I will be checking in Patch Rev 2, but
you can review Patch Rev 2b since it ignores the indentation changes I had to
make, which makes it a bit easier to see what my changes were.

Is this something we want to try and get in for 0.9.6 since it's a regression?
Let me know, I'll have to ask drivers.

	Joe Francis
	Comment 12 • 23 years ago

i think this should go in 096.

	Joe Francis
	Comment 13 • 23 years ago

Comment on attachment 56955 [details] [diff] [review]
Patch Rev 2b (Same as patch above except with diff -uw output)

r=jfrancis; thanks kin

	Simon Fraser [no longer active]
	Comment 14 • 23 years ago

Comment on attachment 56955 [details] [diff] [review]
Patch Rev 2b (Same as patch above except with diff -uw output)

sr=sfraser

	Asa Dotzler [:asa]
	Comment 15 • 23 years ago

a=asa (on behalf of drivers) for checkin to 0.9.6

	kinmoz Assignee
	Comment 16 • 23 years ago

Fix (Patch Rev 2) checked into trunk:

  editor/libeditor/html/nsHTMLDataTransfer.cpp    revision 1.33
  editor/libeditor/html/nsHTMLEditRules.cpp       revision 1.206
  editor/libeditor/html/nsHTMLEditRules.h         revision 1.78
  editor/libeditor/html/nsHTMLEditor.h            revision 1.165
  editor/libeditor/text/nsTextEditRules.h         revision 1.66

	Nathan Reporter
	Comment 17 • 23 years ago

verified 2001110903.

	Christopher Blizzard (:blizzard)
	Comment 18 • 23 years ago

Has this been checked into the 0.9.6 branch yet?

	kinmoz Assignee
	Comment 19 • 23 years ago

Yes, it should be on the MOZILLA_0_9_6_BRANCH, I checked it into the TRUNK
before it was branched.