[Blocking Requested - why for this release]: blocks v2.1 feature (bug 1041765) Looks like we have to update text color of phone/url links inside message bubbles too.

Hey Fang, I see that link styles are untouched by Thread view v2.1 redesign, but I guess we need to update them too. Currently text color for the links is #333 (color for :active/:hover is #ff4e00) for both incoming and outgoing messages, including "sending..." state + links are always underlined. Could you please let me know what style updates we need for the links if any? Thanks!

Hi Oleg, Attached is the new link styles for thread view. Thanks!

triage: put into backlog for now.

(In reply to Fang Shih [:fang] from comment #2) > Created attachment 8487005 [details] > Messaging_link_styles.png > > Hi Oleg, > > Attached is the new link styles for thread view. > Thanks! Great, thanks!

Hi Steve, Here is a tiny patch that updates link styles in accordance with the latest spec. Thanks!

Comment on attachment 8487096 [details] GitHub pull request URL Looks great, thanks! Hi Fang, since this patch only changes the link color, do you think it's safer to ui-review again on this one?

(In reply to Steve Chung [:steveck] from comment #6) > Comment on attachment 8487096 [details] > GitHub pull request URL > > Looks great, thanks! > > Hi Fang, since this patch only changes the link color, do you think it's > safer to ui-review again on this one? Thanks for reminder Steve! I believe it's safer to do anyway :) Added two attachments with default and active states for ui-review. Fang, could you please review it?

Comment on attachment 8488520 [details] Links in default state Looks great!! Thanks!

Thanks! Master: https://github.com/mozilla-b2g/gaia/commit/01f134698b932b0ffbdfa7ec658b5cd5e9b5634b

Comment on attachment 8487096 [details] GitHub pull request URL [Approval Request Comment] [Bug caused by] (feature/regressing bug #): part of v2.1 VR, bug 1041765 [User impact] if declined: phone/url links inside messages look badly with the new thread styles [Testing completed]: yes, ui-review+ [Risk to taking this patch] (and alternatives if risky): very low, tiny targeted css-only change [String changes made]: n/a

v2.1: https://github.com/mozilla-b2g/gaia/commit/e731a63484c532168f4de6dc1eeb4c6612ad73a9

This issue has been successfully verified on Flame 2.1, 2.2 See attachment:flame2.1.png Reproducing rate: 0/5 Flame2.1 new build: Gaia-Rev 5372b675e018b6aac97d95ff5db8d4bd16addb9b Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b Build-ID 20141127001201 Version 34.0 FLame 2.2 new build: Gaia-Rev 80bc1445959db79e9d2e947cc56e1eb7b0d3d0f0 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/7dfad34d265b Build-ID 20141127040204 Version 36.0a1