Karl Tomlinson (:karlt) Assignee
	Description • 10 years ago

Following instructions at 
https://github.com/mozilla/gecko-dev/blob/master/testing/web-platform/README.md#autogenerating-expectation-data

and running the command
  ./mach web-platform-tests-update --no-check-clean wpt.with.mse

with attachment 8485604 [details] [diff] [review] applied yields

git rev-parse --show-cdup
fatal: Not a git repository (or any parent up to mount point /mnt/ssd1)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
{'cwd': u'/mnt/ssd1/karl/moz/dev/testing/web-platform/sync'}

git rev-parse --show-cdup
fatal: Not a git repository (or any parent up to mount point /mnt/ssd1)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
{'cwd': u'/mnt/ssd1/karl/moz/dev/testing/web-platform/sync'}

git rev-parse HEAD
fatal: Not a git repository (or any parent up to mount point /mnt/ssd1)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
{'cwd': u'/mnt/ssd1/karl/moz/dev/testing/web-platform/sync'}

Traceback (most recent call last):
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/update.py", line 306, in update_metadata
    ignore_existing=ignore_existing)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/metadata.py", line 53, in update_expected
    rev_new = git("rev-parse", rev_new, repo=sync_root).strip()
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/vcs.py", line 24, in inner
    return subprocess.check_output(command_line, **proc_kwargs)
  File "/usr/lib64/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['git', 'rev-parse', 'HEAD']' returned non-zero exit status 128
Error running mach:

    ['web-platform-tests-update', '--no-check-clean', 'wpt.with.mse']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

CalledProcessError: Command '['git', 'rev-parse', 'HEAD']' returned non-zero exit status 128

  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/mach_commands.py", line 120, in update_web_platform_tests
    return wpt_updater.run_update(**params)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/mach_commands.py", line 78, in run_update
    update.run_update(**kwargs)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/update.py", line 368, in run_update
    kwargs["run_log"], kwargs["ignore_existing"])
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/update.py", line 306, in update_metadata
    ignore_existing=ignore_existing)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/metadata.py", line 53, in update_expected
    rev_new = git("rev-parse", rev_new, repo=sync_root).strip()
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/vcs.py", line 24, in inner
    return subprocess.check_output(command_line, **proc_kwargs)
  File "/usr/lib64/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)

	James Graham [:jgraham]
	Comment 2 • 10 years ago

Comment on attachment 8485605 [details] [diff] [review]
don't try to rev-parse if there is no git revision

Review of attachment 8485605 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch; it basically looks right, but needs to be fixed upstream, so I adapted it a little and submitted https://critic.hoppipolla.co.uk/r/2533 to make the metadata work without a local repository.

	Karl Tomlinson (:karlt) Assignee
	Comment 3 • 10 years ago

Thank you, James.  That looks more thorough than my patches.

Not much point tracking this separately from bug 1064145.