Closed
Bug 1064185
Opened 10 years ago
Closed 10 years ago
Opening the cardview from the homescreen isn't setting visibility properly
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(b2g-v2.1 affected, b2g-v2.2 affected)
RESOLVED
INVALID
People
(Reporter: etienne, Unassigned)
Details
(Whiteboard: [systemsfe], [2.1-flame-test-run-3])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
The homescreen stays visible causing noticeable performance loss.
Reporter | ||
Updated•10 years ago
|
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
Comment 1•10 years ago
|
||
For the appWindows in the stack, we call enterTaskManager() on them when we render the card. That causes them to transition to closed state. For homescreen, we handle cardviewbeforeshow in HomescreenLauncher and call fadeOut() on the homescreen. But, because homescreen is active in this use case, fadeOut is a no-op.
We could call close() on the homescreen when cardsviewbeforeshow fires, but messing with homescreen state makes me nervous at this stage of the game. I'm thinking of implementing a enterTaskManager on HomescreenWindow that just explicitly adds the 'fadeout' class.
Comment 2•10 years ago
|
||
This breaks the symmetry of the fadeIn/fadeOut calls but looks to give us the right result?
Attachment #8485925 -
Flags: review?(etienne)
Comment 3•10 years ago
|
||
Based on the bug title, perhaps you would prefer if enterTaskManager on HomescreenWindow did this.close('immediate')? I see no handlers for the 'homescreenclose' event that would complicate this. I'm trying to think if there would be other unwanted side-effects?
Updated•10 years ago
|
Whiteboard: [systemsfe]
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to Sam Foster [:sfoster] from comment #3)
> Based on the bug title, perhaps you would prefer if enterTaskManager on
> HomescreenWindow did this.close('immediate')? I see no handlers for the
> 'homescreenclose' event that would complicate this. I'm trying to think if
> there would be other unwanted side-effects?
I don't think it should.
The issue with the current approach is that when you select an app from the cardsview the homescreen fades in again (cardviewbeforeclose) so it'll appear between the sheets when you edge swipe.
In fact I think the main issue here is that the appopening/appopened events are being raced by the cardviewbeforeclose event.
Reporter | ||
Updated•10 years ago
|
Attachment #8485925 -
Flags: review?(etienne)
Updated•10 years ago
|
Whiteboard: [systemsfe] → [systemsfe], [2.1-flame-test-run-3]
Comment 5•10 years ago
|
||
The code this bug refers to was long since re-worked in other bugs
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•