Closed
Bug 1064363
Opened 10 years ago
Closed 10 years ago
Remove unused WebSocket library
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: mfinkle, Assigned: rnewman)
References
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Bug 834033 landed a WebSocket library to support SimplePush. Snorp says this is never going to be used for Push support, so let's remove it. Of the four cset's landed in bug 834033:
https://hg.mozilla.org/mozilla-central/rev/0bf3505c02b2
https://hg.mozilla.org/mozilla-central/rev/05a6210472f1
https://hg.mozilla.org/mozilla-central/rev/c1779b8d2bf1
https://hg.mozilla.org/mozilla-central/rev/a597da48b937
I think the only one we need to back out for WebSockets is:
https://hg.mozilla.org/mozilla-central/rev/c1779b8d2bf1
This cset does package more in our APK, but I don't know if we want the SystemMessage stuff or not. Maybe just remove the Push.js stuff, but DO NOT remove the necko_websocket.xpt stuff:
https://hg.mozilla.org/mozilla-central/rev/05a6210472f1
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
I will probably end up doing this.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8486491 -
Flags: review?(snorp)
Assignee | ||
Comment 3•10 years ago
|
||
Assuming that this isn't used by anything else. It's a DOM API, and I don't think we care.
Attachment #8486492 -
Flags: review?(snorp)
Assignee | ||
Comment 4•10 years ago
|
||
Same. I took a look at this code, and it doesn't seem at all relevant to Fennec.
Attachment #8486494 -
Flags: review?(snorp)
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Because why specify dependencies in one place when two will do?
Attachment #8486525 -
Flags: review?(snorp)
Assignee | ||
Updated•10 years ago
|
Attachment #8486491 -
Attachment is obsolete: true
Attachment #8486491 -
Flags: review?(snorp)
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Try is happy.
Updated•10 years ago
|
Attachment #8486491 -
Flags: review+
Comment 9•10 years ago
|
||
Comment on attachment 8486492 [details] [diff] [review]
Part 2: remove Push.js. v1
Review of attachment 8486492 [details] [diff] [review]:
-----------------------------------------------------------------
We'll need this (or something similar) eventually, I think. Can take it out for now.
Attachment #8486492 -
Flags: review?(snorp) → review+
Comment 10•10 years ago
|
||
Comment on attachment 8486494 [details] [diff] [review]
Part 3: remove SystemMessage stuff. v1
Review of attachment 8486494 [details] [diff] [review]:
-----------------------------------------------------------------
I don't even know what this is, but looks B2G related?
Attachment #8486494 -
Flags: review?(snorp) → review+
Updated•10 years ago
|
Attachment #8486525 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cbcf1d354938
https://hg.mozilla.org/mozilla-central/rev/2c4ae93e8784
https://hg.mozilla.org/mozilla-central/rev/341ae3a743a5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•