Closed
Bug 1064432
Opened 10 years ago
Closed 10 years ago
Add mochitest-webgl.ini as a unified mochitest manifest for webgl tests
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: jgilbert, Assigned: jgilbert)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
Mochitests subsuites can currently only be a single manifest, so let's add a manifest that can be used for this.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8485877 -
Flags: review?(dglastonbury)
Attachment #8485877 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 2•10 years ago
|
||
If we add this combined manifest, I don't think we want to chain in the mochitest directories above.
Attachment #8485877 -
Attachment is obsolete: true
Attachment #8486169 -
Flags: review?(kmoir)
Attachment #8486169 -
Flags: review?(dglastonbury)
Updated•10 years ago
|
Attachment #8486169 -
Flags: review?(kmoir) → review+
Attachment #8486169 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Backed out for breaking the build on all platforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cc6e2c6ea12
https://tbpl.mozilla.org/php/getParsedLog.php?id=47726066&tree=Mozilla-Inbound
Comment 5•10 years ago
|
||
jgilbert: Are there plans to land a modified manifest and address this issue?
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Kim Moir [:kmoir] from comment #5)
> jgilbert: Are there plans to land a modified manifest and address this issue?
Yes, but I have not had much time in the last two weeks.
Flags: needinfo?(jgilbert)
Comment 7•10 years ago
|
||
Okay thanks jgilbert for the status update.
Assignee | ||
Comment 8•10 years ago
|
||
Alright, so I had to do this the hard way.
Bug 1068086 blocks us from using [include:] to pull in a manifest from a different directory, if that mochitest has support-files.
Since support-files in includes don't work from different directories, I needed to pull the mochitest manifests that we wanted to include into the same dir as the including manifest.
I also added an Exception for when 'fail-if' or other invalid keys are in the errata file. This should prevent us from accidentally trying this broken thing.
I added a header to the generated manifest stating that it's generated, and noting how to generate it, and where to mark things as either skipped or expected-fail.
Attachment #8486169 -
Attachment is obsolete: true
Attachment #8492462 -
Flags: review?(dglastonbury)
Comment on attachment 8492462 [details] [diff] [review]
mochigl
Review of attachment 8492462 [details] [diff] [review]:
-----------------------------------------------------------------
Does this need to be reviewed by mochitest people?
::: dom/canvas/test/webgl-conformance/generate-wrappers-and-manifest.py
@@ +34,5 @@
> +# This is a GENERATED FILE. Do not edit it directly.
> +# Regenerated it by using `python generate-wrapper-and-manifest.py`.
> +# Mark skipped tests in mochitest-errata.ini.
> +# Mark failing tests in mochi-single.html.
> +'''.strip()
++!
Attachment #8492462 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•