Closed
Bug 1064485
Opened 10 years ago
Closed 10 years ago
[Search] Clearing Rocketbar search still displays results for last search term
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(b2g-v2.0 unaffected, b2g-v2.1 verified, b2g-v2.2 verified)
VERIFIED
FIXED
2.1 S4 (12sep)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | unaffected |
b2g-v2.1 | --- | verified |
b2g-v2.2 | --- | verified |
People
(Reporter: bzumwalt, Assigned: chens)
References
Details
(Keywords: regression, Whiteboard: [2.1-flame-test-run-2])
Attachments
(6 files)
Description:
With search results enabled, clearing search term by pressing "x" icon after searching for a term in Rocketbar still displays results for cleared search term.
Repro Steps:
1) Update a Flame device to BuildID: 20140908000204
2) Tap Rocketbar
3) Type search term
4) After results appear select "x" icon to clear search term
Actual:
Search results do not disappear along with keyword/search term.
Expected:
Search results disappear along with keyword/search term.
Environmental Variables:
Device: Flame 2.1 (319mb)
BuildID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Notes:
Repro frequency: 3/3, 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/13926/
See attached: screenshot & logcat
Reporter | ||
Comment 1•10 years ago
|
||
Issue DOES occur on Flame 2.2 (319mb), OpenC 2.2, Flame 2.1 (512mb), and OpenC 2.1
Device: Flame Master (319mb)
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
Device: Open_C Master
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
Device: Flame 2.1(512mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Device: Open_C 2.1
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Actual Result: Search results do not disappear along with keyword/search term.
Issue does NOT occur on Flame 2.0 (319mb) or OpenC 2.0
Device: Flame 2.0 (319mb)
Build ID: 20140908000202
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
Device: Open_C 2.0
Build ID: 20140908000202
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
Actual Result: Search results disappear along with keyword/search term.
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.0:
--- → unaffected
status-b2g-v2.2:
--- → affected
Flags: needinfo?(dharris)
Keywords: regression
Reporter | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Can you repro this consistently? I just tried on Flame and wasn't able to repro:
Gaia a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
SourceStamp 746f24f9d21d
BuildID 20140908000204
Version 34.0a2
v. 123
Reporter | ||
Comment 4•10 years ago
|
||
Successfully reproduced issue on multiple devices on same build that you are using Marcia. Checked again just now and issue still reproduces.
Assignee | ||
Comment 5•10 years ago
|
||
Assignee: nobody → shchen
Attachment #8486164 -
Flags: review?(kgrandon)
Comment 6•10 years ago
|
||
Comment on attachment 8486164 [details]
Pull request
So I don't think I can R+ this without seeing if we can fix some of the repercussions of the patch which I think are worse. Currently with this patch, the next keystroke will cause the old results to flash, I think we should try to fix this.
It would be much better if we can go through the clear() path in search.js, here: https://github.com/mozilla-b2g/gaia/blob/master/apps/search/js/search.js#L276
Do you think this is possible?
Attachment #8486164 -
Flags: review?(kgrandon)
Assignee | ||
Comment 7•10 years ago
|
||
I'm not able to reproduce the flashing. Is it occurs when typing keyword to search? or it occurs after hit the clear button and start over a new search? Providing a video to explain my findings [1], on the left hand side is master w/ patch, and right hand side is master (6ff857140361989a2bf11f203f49e074aa85aed3)
[1] http://youtu.be/EwryVzc0FQ4
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8486247 -
Flags: review?(kgrandon)
Comment 9•10 years ago
|
||
Comment on attachment 8486247 [details]
Pull request 2
This is better and removes the flashing for me. Thanks!
Attachment #8486247 -
Flags: review?(kgrandon) → review+
Comment 10•10 years ago
|
||
Updated•10 years ago
|
Comment 11•10 years ago
|
||
Comment on attachment 8486247 [details]
Pull request 2
This is a small patch with a nice improvement for UX that we should be able to safely get into 2.1.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Less than ideal UX, clearing the results will leave them on the screen.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, simple patch and contained to only a new feature.
[String changes made]: None.
Attachment #8486247 -
Flags: approval-gaia-v2.1?(bbajaj)
Updated•10 years ago
|
Attachment #8486247 -
Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
Not nominating this as a blocker. If the user starts another search, the search results will be updated with the new search
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(dharris)
Comment 13•10 years ago
|
||
Target Milestone: --- → 2.1 S4 (12sep)
Comment 14•10 years ago
|
||
This issue has been successfully verified on Flame 2.1:
Gaia-Rev 1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID 20141125001201
Version 34.0
Device-Name flame
FW-Release 4.4.2
This issue has been successfully verified on Flame 2.2:
Gaia-Rev 824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID 20141125040209
Version 36.0a1
Device-Name flame
FW-Release 4.4.2
Comment 15•10 years ago
|
||
This issue has been verified successfully on Flame 2.1 & 2.2.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/20
Flame v2.1 version:
Gaia-Rev db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID 20141126001202
Version 34.0
Flame 2.2 version:
Gaia-Rev 41b7be7c67167f367c3c4982ff08651d55455373
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/ff4a63d66806
Build-ID 20141126160201
Version 36.0a1
You need to log in
before you can comment on or make changes to this bug.
Description
•