KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Description • 10 years ago

Description:
Locking the device right after entering a passcode leaves the user in an unrecoverable state. The slider on the lockscreen will be gone and the user can only enter the camera app. They will have to restart their phone to recover.

Prerequisite: Enable lockscreen and a Passcode in settings. 

Repro Steps:
1)  Updated Flame to Build ID: 20140908000204
2)  Lock the device.
3)  Slide to unlock the lock screen.
4)  Enter a passcode and immediately lock the device.
5)  Wake the device up and notice the lockscreen.

Actual:
The slider to unlock the lockscreen is completely missing and the user will have to restart their phone to recover.

Expected:
The user can unlock their device without issue. 

Environmental Variables:
Device: Flame 2.1(319mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes:
Repro frequency: 100%
See attached: video, logcat

Please see bug 1043892 that was resolved as fixed.

	KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Comment 1 • 10 years ago

This issue also occur on the Flame 2.2(319mb), Open C 2.2, Flame 2.1(512mb) and Open C 2.1.

The slider on the lockscreen will be missing and the user will have to restart their device.

Flame 2.2

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Open C 2.2

Environmental Variables:
Device: Open_C Master 
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1

Environmental Variables:
Device: Flame 2.1(512mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.1

Environmental Variables:
Device: Open_C 2.1 
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

------------------------------------------------------------------------------

This issue also occurs on the Flame 2.0 and Open C 2.0 

It is not as severe though as 2.1 and 2.2 because the user can recover from the issue by relocking their device and waking it up again. 

Flame 2.0

Environmental Variables:
Device: Flame 2.0 (319mb)
Build ID: 20140908000202
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open_C 2.0

Environmental Variables:
Device: Open_C 2.0 
Build ID: 20140908000202
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

--------------------------------------------------------------------------------------

This issue does not occur on the Flame 1.4 and Open C 1.4

The user can unlock their device without issue. 

Flame 1.4

Environmental Variables:
Device: Flame 1.4 (319mb)
Build ID: 20140905123003
Gaia: 2ee5b00bfbb8a67a967094804390b4afce8ecf54
Gecko: a3e8df746cd8
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Open C 1.4

Environmental Variables:
Device: Open_C 1.4 
Build ID: 20140905123003
Gaia: 2ee5b00bfbb8a67a967094804390b4afce8ecf54
Gecko: a3e8df746cd8
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

	KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Comment 2 • 10 years ago

The user has to be in settings when locking their device in step 2 to get this issue to occur.

	Chris Kreinbring [:CKreinbring]
	Comment 3 • 10 years ago

Regression window
Last working
BuildID: 20140823032956
Gaia: e424c85eda87a40c0fa64d6a779c3fa368bf770b
Gecko: daa84204a11a
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken
BuildID: 20140825075549
Gaia: a25ae14dbd2fe3e25144a7064efc0cc4e31042b8
Gecko: 3b29c08f0afa
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Working Gaia / Broken Gecko = No repro
Gaia: e424c85eda87a40c0fa64d6a779c3fa368bf770b
Gecko: 3b29c08f0afa
Broken Gaia / Working Gecko = Repro
Gaia: a25ae14dbd2fe3e25144a7064efc0cc4e31042b8
Gecko: daa84204a11a
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/e424c85eda87a40c0fa64d6a779c3fa368bf770b...a25ae14dbd2fe3e25144a7064efc0cc4e31042b8


B2G inbound
Last working
BuildID: 20140824235254
Gaia: 5fae8a02bc31d28a4a76371bd9b0c8ef98a4b4f4
Gecko: e8efd2cf56e8
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken
BuildID: 20140825011754
Gaia: c36879d1d2644b5e059ef06aa855def460f8e08f
Gecko: 42091f9dd02f
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Working Gaia / Broken Gecko = No repro
Gaia: 5fae8a02bc31d28a4a76371bd9b0c8ef98a4b4f4
Gecko: 42091f9dd02f
Broken Gaia / Working Gecko = Repro
Gaia: c36879d1d2644b5e059ef06aa855def460f8e08f
Gecko: e8efd2cf56e8
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/5fae8a02bc31d28a4a76371bd9b0c8ef98a4b4f4...c36879d1d2644b5e059ef06aa855def460f8e08f

	Derek Harris [:DerekH] - Dont need info. Last day 6/5/15
	Comment 4 • 10 years ago

[Blocking Requested - why for this release]:

Nominating this as a 2.1? blocker, as the user can recover in 2.0. In 2.1 the user will have to restart the device in order to recover from being locked out due to the unlock button missing. This is bad user flow

	Jason Smith [:jsmith]
	Comment 5 • 10 years ago

Derek - Can you analyze the push log, find a suspect bug, and needinfo the relevant dev to take a look?

	Derek Harris [:DerekH] - Dont need info. Last day 6/5/15
	Comment 6 • 10 years ago

Caused by Bug 1043892? Greg, can you take a look?

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 7 • 10 years ago

Seems resolved. This is the log I during I handle this bug. I'll submit the patch later.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 8 • 10 years ago

Waiting Gaia-Try, and set review to see if anything need to correct.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 9 • 10 years ago

Comment on attachment 8487652 [details]
Patch

offline discussion.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 10 • 10 years ago

Comment on attachment 8487652 [details]
Patch

I've updated the patch as Alive commented. Set review again to see if it needs more updates.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 12 • 10 years ago

Waiting Gaia-Try, another 100mins. And I would uplift this after it's become 2.1+, of course also after the approval.

	howie [:howie]
	Comment 13 • 10 years ago

Triage: regression, blocking.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 14 • 10 years ago

The Gij only failed at a Calendar test:

https://tbpl.mozilla.org/?rev=a5c894918390aa5462f95c3a7f03b15397977af4&tree=Gaia-Try

So I would prepare 2.1 patch and land the master version.

For 2.0 I need to check if state machine has been landed in 2.0.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 15 • 10 years ago

master: https://github.com/mozilla-b2g/gaia/commit/59a1e75f2c29907c6d9450262d859896dd0837d7

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 16 • 10 years ago

Handling this but have no chance to submit the v2.1 and (possible) v2.0 patch today. Will do tomorrow.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 17 • 10 years ago

Howie: In v2.0 the code doesn't exist. I now suspect they're not the same symptoms in 2.0 and 2.1. Could we check it again?

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 19 • 10 years ago

Waiting CI.

	Keven Kuo [:kkuo]
	Comment 20 • 10 years ago

Hi! Greg,

I am afraid that 2.0M is affected also. Please confirm. Thanks.

--
Keven

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 21 • 10 years ago

Trying 2.0 and I can confirm the symptom is totally different. So I don't know whether it should be resolved in the same bug here, or we should move to another bug.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 22 • 10 years ago

Since QA leave video of v2.1 bug, this is what I discovered on v2.0:

https://www.youtube.com/watch?v=n01w-hJM3uI&feature=youtu.be

You can see the symptom is not the same. And I know the root cause in v2.1 and master, but for v2.0 it definitely caused by other bug.

	howie [:howie]
	Comment 23 • 10 years ago

Hi Greg, let's fix the 2.1 problem in this bug and open a new one for 2.0. thanks.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 24 • 10 years ago

v2.1 patch passed all tests:

https://tbpl.mozilla.org/?rev=9f825ad99ce2979101bf6976bf6958bf69bdfa1f&tree=Gaia-Try

I now submit the approval form and land it. After that, Howie, could we change the blocking status and open another bug?

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 25 • 10 years ago

Comment on attachment 8492896 [details]
Patch v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1043892
[User impact] if declined: Regression not solved
[Testing completed]: Gaia-Try, and manually test on real device (seem above comment)
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]: No

This patch fixes this regression as I made for master.

	howie [:howie]
	Comment 26 • 10 years ago

Greg will open a bug for the symptom in 2.0. Changing the tags accordingly.

	Joshua Mitchell (Inactive)
	Comment 27 • 10 years ago

cleaning tags

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 28 • 10 years ago

Bug should be closed when the patch reaches master in comment 15.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 29 • 10 years ago

(In reply to howie [:howie] from comment #26)
> Greg will open a bug for the symptom in 2.0. Changing the tags accordingly.

Greg, Howie, what's the 2.0 bug?

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 30 • 10 years ago

I didn't fire it yet (since this one is open and I'm waiting for 2.1). I now open it.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 31 • 10 years ago

Fired: Bug 1072366
But I don't think they're are dependent or caused by the same root cause, especially the relevant code in 2.0 and 2.1 is totally different. So I don't set any flag to connect these two bugs.

	Ryan VanderMeulen [:RyanVM]
	Comment 32 • 10 years ago

Looks like the v2.1 patch needs rebasing.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 33 • 10 years ago

Rebased. Gaia-Try failed only with intermittent bug, which is definitely irrelevant:

https://tbpl.mozilla.org/?rev=044c3bda1b3b6b6f52e4ba23d53d7e97ae9d5f64&tree=Gaia-Try

So I would land the patch.

	Greg Weng [:snowmantw][:gweng][:λ] Assignee
	Comment 34 • 10 years ago

v2.1: https://github.com/mozilla-b2g/gaia/commit/53ace8f43f8087424b7d3b1a959fbfc490d9b941

	Brogan Zumwalt [Inactive]
	Comment 35 • 10 years ago

Issue verified as fixed on Flame 2.1 & Flame 2.2

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master  KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

With lockscreen passcode enabled, turning off screen on settings page then unlocking, putting in passcode and immediately turning off screen again results in a fully functional lockscreen.