Open
Bug 1064875
Opened 10 years ago
Updated 2 years ago
Consider replacing the FilterNodeCompositeSoftware code with Skia compositing through DrawTargetSkia
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
ASSIGNED
People
(Reporter: mstange, Assigned: mstange)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
I think the only argument against this is that the pixman code might not be safe against timing attacks. But if that's the case then we're already vulnerable through more common uses of the code, e.g. through normal web page compositing.
|
Assignee | |
Updated•10 years ago
|
Summary: Consider replacing the FilterNodeCompositeSoftware code with pixman compositing through DrawTargetCairo → Consider replacing the FilterNodeCompositeSoftware code with Skia compositing through DrawTargetSkia
|
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → mstange
Attachment #8486409 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8498664 -
Flags: review?(bas)
|
||
Comment 2•10 years ago
|
||
How about timing attacks with Skia?
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8498664 [details] [diff] [review]
v2
Right, I still need to check that.
Attachment #8498664 -
Flags: review?(bas)
|
||
Comment 4•8 years ago
|
||
Markus, any update on this? Could you unbitrot your patch?
Flags: needinfo?(mstange)
|
|
Assignee | |
Comment 5•8 years ago
|
||
No update, but sure, I can update it.
As for the timing attacks, it's unlikely that Skia is vulnerable to them. Since we're using Skia composition for content drawing on some platforms now (and so is Chrome), we'd be vulnerable already.
Flags: needinfo?(mstange)
|
|
Assignee | |
Comment 6•8 years ago
|
||
For the record: This patch will probably not improve the performance of the feComposite filter on desktop. Last I checked, the SSE2 code I wrote was roughly competitive with Skia.
I did not write a NEON version of the composite filter, but Skia has NEON versions for this, so this patch will definitely improve performance on Android.
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•