Closed
Bug 1064886
Opened 10 years ago
Closed 10 years ago
add "Enable E10S" checkbox to preferences pane
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
| Tracking | Status | |
|---|---|---|
| e10s | m2+ | --- |
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
This would allow flipping the e10s.autostart pref, essentially.
This goes well together with bug 1064885, I think.
|
Assignee | |
Comment 1•10 years ago
|
||
- In-content prefs only, since this is meant to be Nightly-only and temporary.
- This implements a "you must restart to change this pref" prompt, which is mostly copied from privacy.js' "updateAutostart" function
- I just stuck it at the top of the "Startup" section in the main pane
|
||
Comment 2•10 years ago
|
||
Please use the E10S_TESTING_ONLY ifdef.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Screenshot: https://cloudup.com/cM2SgEijMQ9
Screenshot of prompt after clicking checkbox: https://cloudup.com/ceFDlxtlZYC
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8486427 [details] [diff] [review]
patch
Review of attachment 8486427 [details] [diff] [review]:
-----------------------------------------------------------------
r+ with wrapping things in E10S_TESTING_ONLY. For other Nightly-only UI features related to e10s, we've been hardcoding the strings in the code instead of putting them in a .dtd to avoid localizers from having to translate it. Perhaps we should do the same here.
Attachment #8486427 -
Flags: review?(felipc) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Hardcode strings, add E10S_TESTING_ONLY ifdef.
Attachment #8486427 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•10 years ago
|
||
I also changed the checkbox label to "Enable E10S (multi-process)", per bug 1064885 comment 6.
|
|
Assignee | |
Comment 8•10 years ago
|
||
|
|
||
Comment 9•10 years ago
|
||
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #8)
> https://tbpl.mozilla.org/?tree=Try&rev=24217f336b79
Please make sure not to add any code after the main-pane-loaded notification in gMainPane.init.
|
|
Assignee | |
Comment 10•10 years ago
|
||
Pushed with that fixed:
https://hg.mozilla.org/integration/fx-team/rev/b97b76db0e3e
Iteration: --- → 35.1
Points: --- → 3
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Target Milestone: --- → Firefox 35
|
||
Comment 11•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
QA Contact: camelia.badau
|
||
Updated•10 years ago
|
Blocks: old-e10s-m2
|
||
Comment 12•10 years ago
|
||
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 35.0a1 (buildID: 20140914030209).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•