Closed Bug 1064910 Opened 10 years ago Closed 10 years ago

Update Webapp Runtime to work with the new v2 bundle structure of Firefox on OSX

Categories

(Firefox Graveyard :: Webapp Runtime, defect)

All
macOS
defect
Not set
normal

Tracking

(firefox34 fixed, firefox35 fixed)

RESOLVED FIXED
Firefox 35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(1 file)

All non-binary files in the Firefox .app bundle will move from Contents/MacOS to Contents/Resources. The Webapp Runtime needs to be updated to work with this new structure.
Attached patch Patch (deleted) — Splinter Review
This passes all the webapprt tests locally. Will send to Oak and/or Try shortly to confirm.
Comment on attachment 8486452 [details] [diff] [review] Patch Try push is almost completely green, so requesting review (updater xpcshell test failures and gaia python integration test suite failures are handled in separate bugs): https://tbpl.mozilla.org/?tree=Try&rev=7362867ad903
Attachment #8486452 - Flags: review?(myk)
Comment on attachment 8486452 [details] [diff] [review] Patch Review of attachment 8486452 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks for also reformatting the lines to improve readability!
Attachment #8486452 - Flags: review?(myk) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Have you tried running webapprt chrome tests? "./mach webapprt-test-chrome"
Depends on: 1075492
(In reply to Marco Castelluccio [:marco] from comment #7) > Have you tried running webapprt chrome tests? "./mach webapprt-test-chrome" We expect some tests to break that aren't run automatically on try or m-c. In this case, the difference seems to be that we use mach locally and mozharness on our test servers. We knew some breakage was likely and will fix it as it comes up. Thanks for the heads up!
(In reply to Stephen Pohl [:spohl] from comment #8) > (In reply to Marco Castelluccio [:marco] from comment #7) > > Have you tried running webapprt chrome tests? "./mach webapprt-test-chrome" > > We expect some tests to break that aren't run automatically on try or m-c. > In this case, the difference seems to be that we use mach locally and > mozharness on our test servers. We knew some breakage was likely and will > fix it as it comes up. Thanks for the heads up! No worries, the tests aren't run automatically yet (they're run automatically in a separate tree: https://tbpl.mozilla.org/?tree=Cedar).
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: