Closed
Bug 1064910
Opened 10 years ago
Closed 10 years ago
Update Webapp Runtime to work with the new v2 bundle structure of Firefox on OSX
Categories
(Firefox Graveyard :: Webapp Runtime, defect)
Tracking
(firefox34 fixed, firefox35 fixed)
RESOLVED
FIXED
Firefox 35
People
(Reporter: spohl, Assigned: spohl)
References
Details
Attachments
(1 file)
(deleted),
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
All non-binary files in the Firefox .app bundle will move from Contents/MacOS to Contents/Resources. The Webapp Runtime needs to be updated to work with this new structure.
Assignee | ||
Comment 1•10 years ago
|
||
This passes all the webapprt tests locally. Will send to Oak and/or Try shortly to confirm.
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8486452 [details] [diff] [review]
Patch
Try push is almost completely green, so requesting review (updater xpcshell test failures and gaia python integration test suite failures are handled in separate bugs):
https://tbpl.mozilla.org/?tree=Try&rev=7362867ad903
Attachment #8486452 -
Flags: review?(myk)
Comment 3•10 years ago
|
||
Comment on attachment 8486452 [details] [diff] [review]
Patch
Review of attachment 8486452 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Thanks for also reformatting the lines to improve readability!
Attachment #8486452 -
Flags: review?(myk) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/09e4c6245f6d
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment 7•10 years ago
|
||
Have you tried running webapprt chrome tests? "./mach webapprt-test-chrome"
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #7)
> Have you tried running webapprt chrome tests? "./mach webapprt-test-chrome"
We expect some tests to break that aren't run automatically on try or m-c. In this case, the difference seems to be that we use mach locally and mozharness on our test servers. We knew some breakage was likely and will fix it as it comes up. Thanks for the heads up!
Comment 9•10 years ago
|
||
(In reply to Stephen Pohl [:spohl] from comment #8)
> (In reply to Marco Castelluccio [:marco] from comment #7)
> > Have you tried running webapprt chrome tests? "./mach webapprt-test-chrome"
>
> We expect some tests to break that aren't run automatically on try or m-c.
> In this case, the difference seems to be that we use mach locally and
> mozharness on our test servers. We knew some breakage was likely and will
> fix it as it comes up. Thanks for the heads up!
No worries, the tests aren't run automatically yet (they're run automatically in a separate tree: https://tbpl.mozilla.org/?tree=Cedar).
Comment 10•10 years ago
|
||
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•