Closed
Bug 106495
Opened 23 years ago
Closed 17 years ago
js_strtod and js_strtointeger shouldn't require NUL termination
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: brendan, Assigned: igor)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
igor
:
review+
brendan
:
approval1.9+
|
Details | Diff | Splinter Review |
See bug 56940. The string length or a fencepost pointer computed by adding
length to chars (cp) should do the trick. Low priority bug.
/be
|
||
Comment 1•23 years ago
|
||
2x posted
*** This bug has been marked as a duplicate of 106494 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
|
Reporter | |
Comment 3•23 years ago
|
||
*** Bug 106494 has been marked as a duplicate of this bug. ***
|
|
Reporter | |
Comment 4•23 years ago
|
||
No typo in my comment here, this is the one not to dup.
/be
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
|
|
Reporter | |
Updated•23 years ago
|
Status: REOPENED → ASSIGNED
|
||
Updated•23 years ago
|
Target Milestone: --- → mozilla0.9.8
|
|
||
Updated•23 years ago
|
Target Milestone: mozilla0.9.9 → mozilla1.0.1
|
||
Updated•19 years ago
|
Assignee: khanson → general
Status: ASSIGNED → NEW
QA Contact: pschwartau → general
Target Milestone: mozilla1.0.1 → ---
|
Assignee | |
Comment 6•17 years ago
|
||
This is a quilt patch. I will post cvs diff version after resolving bug 389880.
Assignee: general → igor
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 7•17 years ago
|
||
Here is cvs diff for a new version of the patch with a fix for js_strtod to ensure that temporary buffer is always 0-terminated.
Attachment #274220 -
Attachment is obsolete: true
Attachment #274293 -
Flags: review?(brendan)
|
|
Reporter | |
Comment 8•17 years ago
|
||
Comment on attachment 274293 [details] [diff] [review]
implementation v2
Thanks, r=me.
/be
Attachment #274293 -
Flags: review?(brendan) → review+
|
|
Assignee | |
Comment 9•17 years ago
|
||
I checked in the patch from comment 7 to the trunk:
Checking in jsnum.c;
/cvsroot/mozilla/js/src/jsnum.c,v <-- jsnum.c
new revision: 3.83; previous revision: 3.82
done
Checking in jsnum.h;
/cvsroot/mozilla/js/src/jsnum.h,v <-- jsnum.h
new revision: 3.30; previous revision: 3.29
done
Checking in jsscan.c;
/cvsroot/mozilla/js/src/jsscan.c,v <-- jsscan.c
new revision: 3.130; previous revision: 3.129
done
Checking in jsstr.c;
/cvsroot/mozilla/js/src/jsstr.c,v <-- jsstr.c
new revision: 3.155; previous revision: 3.154
done
Checking in jsstr.h;
/cvsroot/mozilla/js/src/jsstr.h,v <-- jsstr.h
new revision: 3.41; previous revision: 3.40
done
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•17 years ago
|
||
I baked out the last commit to wait until the tree will be opened:
Checking in jsnum.c;
/cvsroot/mozilla/js/src/jsnum.c,v <-- jsnum.c
new revision: 3.84; previous revision: 3.83
done
Checking in jsnum.h;
/cvsroot/mozilla/js/src/jsnum.h,v <-- jsnum.h
new revision: 3.31; previous revision: 3.30
done
Checking in jsscan.c;
/cvsroot/mozilla/js/src/jsscan.c,v <-- jsscan.c
new revision: 3.131; previous revision: 3.130
done
Checking in jsstr.c;
/cvsroot/mozilla/js/src/jsstr.c,v <-- jsstr.c
new revision: 3.156; previous revision: 3.155
done
Checking in jsstr.h;
/cvsroot/mozilla/js/src/jsstr.h,v <-- jsstr.h
new revision: 3.42; previous revision: 3.41
done
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 11•17 years ago
|
||
This is the patch to commit when the tree will be opened. v2 contained unrelated changes.
Attachment #274293 -
Attachment is obsolete: true
Attachment #274918 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Flags: blocking1.9?
|
|
Reporter | |
Updated•17 years ago
|
Attachment #274918 -
Attachment is patch: true
Attachment #274918 -
Attachment mime type: text/x-patch → text/plain
|
|
Reporter | |
Updated•17 years ago
|
Attachment #274918 -
Flags: approval1.9+
|
|
Assignee | |
Comment 12•17 years ago
|
||
I checked in the patch from comment 11 to the trunk:
Checking in jsnum.c;
/cvsroot/mozilla/js/src/jsnum.c,v <-- jsnum.c
new revision: 3.87; previous revision: 3.86
done
Checking in jsnum.h;
/cvsroot/mozilla/js/src/jsnum.h,v <-- jsnum.h
new revision: 3.34; previous revision: 3.33
done
Checking in jsscan.c;
/cvsroot/mozilla/js/src/jsscan.c,v <-- jsscan.c
new revision: 3.134; previous revision: 3.133
done
Checking in jsstr.c;
/cvsroot/mozilla/js/src/jsstr.c,v <-- jsstr.c
new revision: 3.159; previous revision: 3.158
done
Checking in jsstr.h;
/cvsroot/mozilla/js/src/jsstr.h,v <-- jsstr.h
new revision: 3.45; previous revision: 3.44
done
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 13•17 years ago
|
||
Clearing blocking 1.9 ? flag as the bug was fixed based on 1.9 approval for the checked-in patch.
Flags: blocking1.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•