Closed Bug 1065141 Opened 10 years ago Closed 10 years ago

todo message "OMTA is working" is confusing, in mochitest output

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

When running test_transitions_per_property.html locally, I get this result in my browser-window when the test is complete: > Passed: 24102 > Failed: 0 > Todo: 1 > > todo | OMTA is working The "todo | OMTA is working" message there is phrased incorrectly, which makes it hard to interpret. I initially read it and thought, 'Why are we printing a todo() for something that "is working"'? I think it means to say something like: "Ideally OMTA should work, though we don't currently expect it to work on your platform." Here's the code in question: 91 var expectOMTA = utils.layerManagerRemote && 92 // ^ Off-main thread animation cannot be used if off-main 93 // thread composition (OMTC) is not available 94 SpecialPowers.getBoolPref(OMTAPrefKey); 95 96 isOMTAWorking().then(function(isWorking) { 97 if (expectOMTA) { [...] 107 } else { 108 todo(isWorking, "OMTA is working"); 109 aOnSkip(); 110 } Filing this bug on clarifying that message.
(ideally, test failure messages should describe expected results, rather than saying "$X is the case" or "$Y works" or "$Z failed"; that makes them easier to interpret, regardless of whether you're reading a log where the test passed or failed.)
Attached patch fix v1 (deleted) — Splinter Review
(Let me know if you have any suggestions for better ways to phrase these messages.)
Attachment #8486786 - Flags: review?(birtles)
Comment on attachment 8486786 [details] [diff] [review] fix v1 Looks good, thanks.
Attachment #8486786 - Flags: review?(birtles) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: