Closed Bug 1065182 Opened 10 years ago Closed 10 years ago

Clean up vestigial forward-decl & namespace block in nsICanvasRenderingContextInternal.h and WebGLContext.h

Categories

(Core :: Graphics: CanvasWebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file, 1 obsolete file)

nsICanvasRenderingContextInternal.h currently has this at the end: >135 namespace mozilla { >136 namespace dom { >137 >138 } >139 } This was added in this cset, with something actually inside of that namespace: http://hg.mozilla.org/mozilla-central/diff/9feb8257666c/content/canvas/public/nsICanvasRenderingContextInternal.h ...but that something was removed here, leaving behind an empty namespace block: https://hg.mozilla.org/mozilla-central/diff/ab05eadb67c9/content/canvas/public/nsICanvasRenderingContextInternal.h
Assignee: nobody → dholbert
While we're at it, this header has a forward-decl for ipc::Shmem, which is no longer needed. That forward-decl was added here: http://hg.mozilla.org/mozilla-central/diff/7d65393c8c73/content/canvas/public/nsICanvasRenderingContextInternal.h ...and its usage was removed here: http://hg.mozilla.org/mozilla-central/diff/8eb26a77a90e/content/canvas/public/nsICanvasRenderingContextInternal.h
Summary: nsICanvasRenderingContextInternal.h has a vestigial empty namespace block at the end → Clean up vestigial forward-decl & namespace block in nsICanvasRenderingContextInternal.h
OS: Linux → All
Hardware: x86_64 → All
Attached patch fix (obsolete) (deleted) — Splinter Review
Attachment #8486867 - Flags: review?(jgilbert)
Actually, last patch doesn't compile, because we still have a vestigial implementation of the (long-since removed) Shmem-using function "Swap", in WebGLContext.h. (and it relied on the forward-declare that I'm removing) The vestigial "Swap()" implementations should be removed, since they were taken out of the API, as shown in the link at the end of comment 1. This patch updates WebGLContext.h to remove them, and also marks the adjacent function "Redraw" as MOZ_OVERRIDE, so that if it's ever removed from the API, we'll notice that we've got this vestigial version lying around and know to remove it. :)
Attachment #8486867 - Attachment is obsolete: true
Attachment #8486867 - Flags: review?(jgilbert)
Attachment #8486875 - Flags: review?(jgilbert)
Attachment #8486875 - Flags: review?(jgilbert) → review+
Summary: Clean up vestigial forward-decl & namespace block in nsICanvasRenderingContextInternal.h → Clean up vestigial forward-decl & namespace block in nsICanvasRenderingContextInternal.h and WebGLContext.h
Component: Canvas: 2D → Canvas: WebGL
Sanity-check Try run (builds only): https://tbpl.mozilla.org/?tree=Try&rev=a70b8a933ac1
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: