Closed
Bug 1065492
Opened 10 years ago
Closed 10 years ago
Some videos thumbnails are rendered with shear
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1064126 +++
This bug is created based on Bug 1064126 Comment 8.
video thumbnail of a video of Bug 889238 does not rendered correctly on v2.0 flame. It seems rendered with shear.
Assignee | ||
Comment 1•10 years ago
|
||
[Blocking Requested - why for this release]: User can see the video thumbnail's problem.
blocking-b2g: --- → 2.0?
Assignee | ||
Comment 3•10 years ago
|
||
I am going to investigate about where causes the problem.
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 4•10 years ago
|
||
Video app's card view's video is already sheared video. ConvertOmxYUVFormatToRGB565() seems to cause the problem.
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.cpp#265
Comment 5•10 years ago
|
||
Based on an IRC conversation with Sotaro yesterday, this problem only with videos of sizes in multiples of 8 and therefore is not a normal case. Sotaro is investigating it though.
Sotaro: Based on your investigation, if the impact of this ends up being huge, please renom with an update based on your findings.
At this point in the 2.0 release only show-stopping issues are taken in (https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block). So removing from 2.0 nom.
blocking-b2g: 2.0? → ---
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Hema Koka [:hema] from comment #5)
> Based on an IRC conversation with Sotaro yesterday, this problem only with
> videos of sizes in multiples of 8 and therefore is not a normal case.
The video's width is multiples of 4.
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> (In reply to Hema Koka [:hema] from comment #5)
> > Based on an IRC conversation with Sotaro yesterday, this problem only with
> > videos of sizes in multiples of 8 and therefore is not a normal case.
>
> The video's width is multiples of 4.
Sorry, the video's width is multiples of 2.
Assignee | ||
Comment 8•10 years ago
|
||
DataSourceSurface's stride is always aligned to 16 Byte. It is not cared when doing color convert by using android::ColorConverter. Stride and width becomes different only when a video width is less than 4.
Component: Gaia::Video → Graphics: Layers
Product: Firefox OS → Core
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8488778 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 11•10 years ago
|
||
[Blocking Requested - why for this release]: When the problem happens the user can easily recognize it.
The fix is low risk.
blocking-b2g: --- → 2.0?
Updated•10 years ago
|
Attachment #8488778 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment 14•10 years ago
|
||
Removing qawanted tag due to bug being marked as fixed.
Updated•10 years ago
|
Flags: needinfo?(jmitchell)
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•