Closed Bug 1065492 Opened 10 years ago Closed 10 years ago

Some videos thumbnails are rendered with shear

Categories

(Core :: Graphics: Layers, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1064126 +++ This bug is created based on Bug 1064126 Comment 8. video thumbnail of a video of Bug 889238 does not rendered correctly on v2.0 flame. It seems rendered with shear.
[Blocking Requested - why for this release]: User can see the video thumbnail's problem.
blocking-b2g: --- → 2.0?
QA Wanted for branch checks.
Keywords: qawanted
I am going to investigate about where causes the problem.
Assignee: nobody → sotaro.ikeda.g
Video app's card view's video is already sheared video. ConvertOmxYUVFormatToRGB565() seems to cause the problem. http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.cpp#265
Based on an IRC conversation with Sotaro yesterday, this problem only with videos of sizes in multiples of 8 and therefore is not a normal case. Sotaro is investigating it though. Sotaro: Based on your investigation, if the impact of this ends up being huge, please renom with an update based on your findings. At this point in the 2.0 release only show-stopping issues are taken in (https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block). So removing from 2.0 nom.
blocking-b2g: 2.0? → ---
(In reply to Hema Koka [:hema] from comment #5) > Based on an IRC conversation with Sotaro yesterday, this problem only with > videos of sizes in multiples of 8 and therefore is not a normal case. The video's width is multiples of 4.
(In reply to Sotaro Ikeda [:sotaro] from comment #6) > (In reply to Hema Koka [:hema] from comment #5) > > Based on an IRC conversation with Sotaro yesterday, this problem only with > > videos of sizes in multiples of 8 and therefore is not a normal case. > > The video's width is multiples of 4. Sorry, the video's width is multiples of 2.
DataSourceSurface's stride is always aligned to 16 Byte. It is not cared when doing color convert by using android::ColorConverter. Stride and width becomes different only when a video width is less than 4.
Component: Gaia::Video → Graphics: Layers
Product: Firefox OS → Core
Attachment #8488778 - Flags: review?(nical.bugzilla)
[Blocking Requested - why for this release]: When the problem happens the user can easily recognize it. The fix is low risk.
blocking-b2g: --- → 2.0?
Attachment #8488778 - Flags: review?(nical.bugzilla) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Removing qawanted tag due to bug being marked as fixed.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawanted
Flags: needinfo?(jmitchell)
denominate 2.0?
blocking-b2g: 2.0? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: