I think some accessor behavior is still controlled by JSPROP_SHARED, so I would expect bugs if we're failing to specify it when defining accessor properties.

Comment on attachment 8487809 [details] [diff] [review] Assert that JSPROP_SHARED is set on all properties defined with JSPROP_GETTER or JSPROP_SETTER. try: -b d -p macosx64,win32 -u all[10.8,6.2] -t none Review of attachment 8487809 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsapi-tests/testDefinePropertyIgnoredAttributes.cpp @@ +46,5 @@ > JS::RootedValue defineValue(cx); > > // Try a getter. Allow it to fill in the defaults. > CHECK(JS_DefineProperty(cx, obj, "foo", defineValue, > + IgnoreAll | JSPROP_NATIVE_ACCESSORS | JSPROP_SHARED, Hum, I thought JSPROP_NATIVE_ACCESSORS was only for JSPropertySpec entries. Maybe I'm wrong.

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #4) > Hum, I thought JSPROP_NATIVE_ACCESSORS was only for JSPropertySpec entries. > Maybe I'm wrong. It is a "shallow" feature, dispensed with in jsapi.cpp:DefinePropertyById, but all the JS_Define* APIs go through there.

Comment on attachment 8487809 [details] [diff] [review] Assert that JSPROP_SHARED is set on all properties defined with JSPROP_GETTER or JSPROP_SETTER. try: -b d -p macosx64,win32 -u all[10.8,6.2] -t none Approval Request Comment [Feature/regressing bug #]: Various [User impact if declined]: Blocks uplift for bug 1042567 [Describe test coverage new/current, TBPL]: Been cooking on [Risks and why]: None. Sanifies a few existing calls for the addition of an assert. [String/UUID change made/needed]: None

Comment on attachment 8487809 [details] [diff] [review] Assert that JSPROP_SHARED is set on all properties defined with JSPROP_GETTER or JSPROP_SETTER. try: -b d -p macosx64,win32 -u all[10.8,6.2] -t none Beta+

Comment on attachment 8487809 [details] [diff] [review] Assert that JSPROP_SHARED is set on all properties defined with JSPROP_GETTER or JSPROP_SETTER. try: -b d -p macosx64,win32 -u all[10.8,6.2] -t none Approving given the blocking issue.

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/6fab869fe612 https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/9b229efe2402