Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Description • 10 years ago

It's defined in jsmath.cpp, but not declared in jsmath.h leading to jit/ExecutableAllocatorWin.cpp and vm/ThreadPool.cpp to declare it themselves and use it.

Instead, we should just declare it in jsmath.h.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 1 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=9b35fd1f6e9c

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 2 • 10 years ago

Updated to also expose random_initState and random_nextDouble, because we want to be able to have our own rng state that we can control to get deterministic testing in bug 1056373 and we are using a double between 0 and 1.

Try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5f3c765da94e

	Jason Orendorff [:jorendorff]
	Comment 3 • 10 years ago

Comment on attachment 8488813 [details] [diff] [review]
declare-random_next.patch

Review of attachment 8488813 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a4f865960cd3

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/a4f865960cd3