Lucas Rocha (:lucasr) Assignee
	Description • 10 years ago

mhaigh did the right thing (tm) in his recent adapter changes (i.e. using inflate(int,ViewGroup,boolean) instead of inflate(int,null)) but that exposed a little bug in TwoWayView when using invalid layout params in child views.

	Lucas Rocha (:lucasr) Assignee
	Comment 2 • 10 years ago

In case you're wondering why this is happening...

When you use inflate(id, null), the inflated view will fallback to the container's default LayoutParams. This is not a good practice and leads to confusion. See this blog post for more context: http://www.doubleencore.com/2013/05/layout-inflation-as-intended/

When you use inflate(id, parent, false) though, the inflated view's LayoutParams are taken into account when adding it to its container later. In this case, the container is supposed to validate their child LayoutParams (checkLayoutParams(LayoutParams)) and create a new one if validation fails (generateLayoutParams(LayoutParams)). TwoWayView is accepting invalid LayoutParams which causes the child views to be incorrectly measured.

I could fix TwoWayView now but it's a riskier change at this point. I filed bug 1065672 to track the TwoWayView bug. For now, this is the simplest solution. And using width=match_parent in tabs_item_cell doesn't really make sense anyway.

	Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]
	Comment 3 • 10 years ago

Comment on attachment 8487518 [details] [diff] [review]
Use correct layout param for TwoWayView in tabs_item_cell (r=mcomella)

Review of attachment 8487518 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense because the the content size is not defined in terms of the parent width (which would change from match_parent -> wrap_content).

	Lucas Rocha (:lucasr) Assignee
	Comment 4 • 10 years ago

https://hg.mozilla.org/projects/larch/rev/125cc63143af

	Carsten Book [:Tomcat]
	Comment 5 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/125cc63143af