Closed
Bug 1065679
Opened 10 years ago
Closed 10 years ago
App should not restart when starting to debug it
Categories
(DevTools Graveyard :: WebIDE, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: kgrandon, Assigned: jryans)
References
Details
(Whiteboard: [status:landedon])
Attachments
(1 file)
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
I noticed that recently that the app will restart when connecting the webIDE to debug it. Is there any way that we can prevent this from happening? Sometimes we'll get an app into a certain state and want to debug it when the debugger is not attached. Having the app restart means we lose this state that we want.
Firefox Version: 35.0a1 (2014-09-10)
FxOS Version: 2.2
Assignee | ||
Updated•10 years ago
|
Blocks: gaia-devtools
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Today, when a runtime app is selected we:
* Launch the app if it is not running OR
* Reload the app if it is running
Instead, what we should do is:
* Launch the app if it is not running OR
* Bring the app to the front if it is running
But today, we don't have actor support to say "bring to front". Alex, do you know how we might implement that on the actor side?
Flags: needinfo?(poirot.alex)
Comment 2•10 years ago
|
||
I think you don't need anything on the actor side.
It looks like you just want to always and only call `start` actor method,
which should bring the app to front when already running.
Flags: needinfo?(poirot.alex)
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Alexandre Poirot [:ochameau] from comment #2)
> I think you don't need anything on the actor side.
> It looks like you just want to always and only call `start` actor method,
> which should bring the app to front when already running.
Ah, it does work! I was just confused since we skip it if the app is "running", but in this case we want to just call it anyway.
Assignee | ||
Comment 4•10 years ago
|
||
This is pretty straightforward... except the comparison change in |set selectedProject|. I don't really follow why it's now suddenly necessary to compare the JSON instead of the objects directly.
To test this, I open a runtime app, like Clock. Then I select the same app again. Without the comparison change, the same app is seen as new. Also, the comparison change is not needed without the rest of this changeset... :/
Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2e865db7dd8e
Attachment #8488256 -
Flags: review?(paul)
Comment 5•10 years ago
|
||
Comment on attachment 8488256 [details] [diff] [review]
Avoid reloading runtime apps on select
browser/devtools/webide/modules/app-manager.js
> set selectedProject(value) {
>- if (value != this.selectedProject) {
>+ // A regular comparison still sees a difference when equal in some cases
>+ if (JSON.stringify(this._selectedProject) !==
>+ JSON.stringify(value)) {
Right. Makes me sad.
Attachment #8488256 -
Flags: review?(paul) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Whiteboard: [status:inflight]
Comment 6•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [status:inflight] → [status:inflight][fixed-in-fx-team]
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [status:inflight][fixed-in-fx-team] → [status:inflight]
Target Milestone: --- → Firefox 35
Assignee | ||
Updated•10 years ago
|
Whiteboard: [status:inflight] → [status:landedon]
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•