Closed Bug 1065712 Opened 10 years ago Closed 10 years ago

Move new_tablet_* to the appropriate directories

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

For example, new_tablet_tab_strip is in layout/ - it should be in layout-large-v11/. Also, we may have added layout files that are not prepended with new_tablet_*, but are only used on tablets - be sure to move these as well. It's also possible that these files reference new styles and such in the values/ directory - these should be modified too.
Our non-tablet users thank you in advance for your diligence :D
Blocks: fatfennec
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Comment on attachment 8487631 [details] [diff] [review] Move new_tablet_* resources to *large* directories Review of attachment 8487631 [details] [diff] [review]: ----------------------------------------------------------------- I'm still seeing a few resources in the layouts folder (new_tablet_tab_strip, new_tablet_tabs_counter) and some resource starting with new_tablet_ still in the drawable folder. ::: mobile/android/base/resources/values-large-v11/styles.xml @@ +21,5 @@ > <item name="android:layout_marginLeft">@dimen/forward_default_offset</item> > </style> > > + <style name="UrlBar.ImageButton.TabCount.NewTablet"> > + <item name="android:background">@drawable/new_tablet_tabs_count</item> move the file referenced here from the drawable folder
Attachment #8487631 - Flags: review?(mhaigh) → review-
Comment on attachment 8487631 [details] [diff] [review] Move new_tablet_* resources to *large* directories Sorry, didn't spot the file moves in there! Looks good
Attachment #8487631 - Flags: review- → review+
Yeah, unfortunately the file diff... splinter-ed. :D For future travellers: apply locally - the renamed files don't appear on bugzilla.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: