As we we'll show title in the tab strip anyway. No need to show title twice in the UI.

Sounds good to me!

And it's like more desktop too!

Comment on attachment 8488282 [details] [diff] [review] Part 1: Always show the url in the toolbar on new tablet Review of attachment 8488282 [details] [diff] [review]: ----------------------------------------------------------------- Nice. ::: mobile/android/base/toolbar/ToolbarDisplayLayout.java @@ +322,5 @@ > return; > } > > // If the pref to show the URL isn't set, just use the tab's display title. > + if (!mPrefs.shouldShowUrl(getContext()) || url == null) { I think you can just use mActivity instead of getContext() here.

Comment on attachment 8488285 [details] [diff] [review] Part 2: Remove title in toolbar preference on new tablet Review of attachment 8488285 [details] [diff] [review]: ----------------------------------------------------------------- You probably need to update testSettingsMenuItems accordingly. ::: mobile/android/base/preferences/GeckoPreferences.java @@ +726,5 @@ > return true; > } > }); > + } else if (PREFS_DISPLAY_TITLEBAR_MODE.equals(key) && > + NewTabletUI.isEnabled(getApplicationContext())) { It's safe to just use 'this' instead of getApplicationContext() here.

Address nit.

Address nit.

Tests in part 3.

try for part 3 (comment 10): https://tbpl.mozilla.org/?tree=Try&rev=90ec2f68e989

Comment on attachment 8488947 [details] [diff] [review] Part 3: Update testSettingsMenuItems Review of attachment 8488947 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.

https://hg.mozilla.org/integration/fx-team/rev/84d550c7cee2 https://hg.mozilla.org/integration/fx-team/rev/74e510d20ad3 https://hg.mozilla.org/integration/fx-team/rev/f00d45e4c159

https://hg.mozilla.org/mozilla-central/rev/84d550c7cee2 https://hg.mozilla.org/mozilla-central/rev/74e510d20ad3 https://hg.mozilla.org/mozilla-central/rev/f00d45e4c159