Closed Bug 1066407 Opened 10 years ago Closed 3 years ago

Add a possibly bounded source operator

Categories

(Core :: Graphics, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Details

Attachments

(2 files)

Several of our backends offer us a bounded source operator, and could be faster if we used it (D2D 1.1 has a bounded source option, Cairo is currently doing a clear to facilitate unbounded source). However some also offer no support, this patch adds an OP_SOURCE_MAY_BOUND, which means the user does not care whether the operator bounds the operation (i.e. they know they're filling the entire clipped region). This allows Canvas to get speced behavior and us still to get fast behavior on D2D 1.1 (and improved behavior on Canvas).
Attachment #8488392 - Attachment description: add-bounded-source → Add OP_SOURCE_MAY_BOUND to Moz2D and implement on all backends
Attachment #8488392 - Attachment is patch: true
Attachment #8488392 - Flags: review?(jmuizelaar)
Attachment #8488392 - Attachment description: Add OP_SOURCE_MAY_BOUND to Moz2D and implement on all backends → Part 1: Add OP_SOURCE_MAY_BOUND to Moz2D and implement on all backends
Attachment #8488393 - Flags: review?(matt.woodrow)
Comment on attachment 8488393 [details] [diff] [review] Part 2: Use OP_SOURCE_MAY_BOUND inside RotatedBuffer We're going to discuss this further at the next work week.
Attachment #8488393 - Flags: review?(matt.woodrow)
Comment on attachment 8488392 [details] [diff] [review] Part 1: Add OP_SOURCE_MAY_BOUND to Moz2D and implement on all backends Review of attachment 8488392 [details] [diff] [review]: ----------------------------------------------------------------- Into the trash!
Attachment #8488392 - Flags: review?(jmuizelaar) → review-
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: