Closed
Bug 1066588
Opened 10 years ago
Closed 10 years ago
don't show e10s notification for Talos
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 35
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
I got a bunch of Talos regression emails after landing bug 1064885. Presumably because the notification is now interfering with the test. It shouldn't show up there.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8488601 [details] [diff] [review]
patch
Review of attachment 8488601 [details] [diff] [review]:
-----------------------------------------------------------------
looks great. Do we need this on android? If we do I need to upload a talos.zip.
next steps:
land this in the talos repo
[talos.zip if needed]
update testing/talos/talos.json (in m-c)
land talos.json changes on integration branch
Attachment #8488601 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks for the quick turnaround and tips, Joel.
https://hg.mozilla.org/integration/fx-team/rev/0a03eb20fac5
Target Milestone: --- → Firefox 35
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 5•10 years ago
|
||
Apparently the prompt returned, and apparently it's now hanging off a new pref browser.displayedE10SPrompt.1 (the previous pref didn't have '.1').
Reprompting after the user explicitly answered "No, thank you" is rather pushy, isn't it?
|
|
Assignee | |
Comment 6•10 years ago
|
||
Yes, it is! I love it!
|
|
Assignee | |
Comment 7•10 years ago
|
||
Did we end up fixing this for prompt v2 in-product somehow? Is Talos still affected?
Flags: needinfo?(felipc)
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•