Closed
Bug 1066774
Opened 10 years ago
Closed 10 years ago
Region is always RoW in Chrome
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
2014-10-14
People
(Reporter: cvan, Assigned: mat)
References
()
Details
1. Load the Marketplace in Chrome <https://marketplace.firefox.com/>
2. In your console enter `localStorage.clear()`
3. Search for ":debug"
4. Click "Clear offline cache" and reload the page.
5. Notice the footer says "Rest of the World."
Expected results:
United States
Actual results:
Rest of the World in Chrome, but United States in Firefox.
Assignee | ||
Comment 1•10 years ago
|
||
I think it might be the race condition between mobilenetwork and consumer-info that I'm planning to handle in bug 1048896.
Updated•10 years ago
|
Assignee: nobody → mpillard
Priority: -- → P4
Assignee | ||
Comment 2•10 years ago
|
||
https://github.com/mozilla/fireplace/pull/663 should fix this
Status: NEW → ASSIGNED
Target Milestone: --- → 2014-09-23
Assignee | ||
Updated•10 years ago
|
Target Milestone: 2014-09-23 → 2014-09-30
Assignee | ||
Comment 3•10 years ago
|
||
Fixed in https://github.com/mozilla/fireplace/commit/e1bb494374337d9f5c569827b9612c954925794a
See comment 0 for STR, applies with every other supported region, not just "United States". I used to be able to reproduce the bug from France, now that my fix is in I can't, I'm seen in the right region and not "Rest of World".
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 4•10 years ago
|
||
This still shows up as RoW for me in Chrome.
https://www.dropbox.com/s/elvlxvhmo5m8h4t/Screenshot%202014-09-30%2011.18.57.png?dl=0
The screenshot is from after the push.
ashes: 03ba5
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•10 years ago
|
||
Uh, from your ashes though the API calls are made with the right region... I suspect somehow the footer is rendered before we know the region then. I'll investigate.
Assignee | ||
Comment 6•10 years ago
|
||
Confirming, just a display issue now - https://github.com/mozilla/fireplace/pull/688 should take care of it.
Status: REOPENED → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Target Milestone: 2014-09-30 → 2014-10-07
Assignee | ||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: 2014-10-07 → 2014-10-14
Comment 9•10 years ago
|
||
verified fixed at https://marketplace.allizom.org/
https://www.dropbox.com/s/hqqiseuyxhdfirx/Screenshot%202014-10-13%2011.35.48.png?dl=0
Status: RESOLVED → VERIFIED
Flags: needinfo?(krupa.mozbugs)
Comment 10•10 years ago
|
||
Works on stage but is still broken on prod using Chrome :(
https://www.dropbox.com/s/u3nvs73o0db5uid/Screenshot%202014-10-14%2012.43.24.png?dl=0
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•10 years ago
|
||
Please submit new ashes.
Comment 12•10 years ago
|
||
(In reply to Mathieu Pillard [:mat] from comment #11)
> Please submit new ashes.
Sorry, forgot to add ashes in the rush of shipping.
ID: 4ad46.
Assignee | ||
Comment 13•10 years ago
|
||
I believe the bug here is actually fixed, it's just that the production JavaScript does not match the tag. This is caused by bug 1083185.
Assignee | ||
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•