STR: Create a Contact List with scrolling (>10 contacts, for instance). Go to Contacts Search. The keyboard appears. Then cancel search. The photo/image of the contacts that were behind the keyboard will be lost. note: This can also be reproduced by scrolling fast using the alpha scroll component.

[Blocking Requested - why for this release]: Bad and inconsistent UX

Regarding to search mode: When user enter in search mode and exit from this view the images behind keyboard are not loaded (if you scroll a bit they appear again). The problem is: 1) User enter in search mode 2) The visibility monitor calls to offscreen callback and the list releases images behind keyboard (it is a bit strange because if we are in offscreen no rows should be displayed not only rows behind keyboard) 3) User exit from search mode 4) The visibility monitor calls to onscreen callback but it does not call to reload method of the image loader component. I changed it in order to call imgLoader.reload() but the offsetHeight for items is 0 (again it is strange because if we are onscreen items should have been displayed) In the end I decided not to release images in the offscreen method when we enter in search mode and it works fine

The same happens when importing a new Facebook Contact.

Comment on attachment 8489910 [details] Github pull request works perfectly for me, please ask for review and deal with tests if necessary

The image loader component obtains the item height from the first one so currently the first <li> in the DOM is one that belongs to ICE group. It will be fixed changing the selector 'li' with 'li:not([data-group="ice"])' (In reply to Jose Manuel Cantera from comment #3) > The same happens when importing a new Facebook Contact.

Comment on attachment 8489910 [details] Github pull request Please take a look, thanks

Comment on attachment 8489910 [details] Github pull request I left a tiny comment on GH. great work. thanks

Merged in master: https://github.com/mozilla-b2g/gaia/commit/284e3efdf70cca114bc50ff8596eee6bdab0ae83

triage: blocking bug, we are "loosing" the photos (at least they are not shown to the user)

Please request Gaia v2.1 approval on this patch when you get a chance.

Comment on attachment 8489910 [details] Github pull request [Approval Request Comment] [Bug caused by] (feature/regressing bug #): ICE contacts [User impact] if declined: very high, no photos once contacts are imported from all sources [Testing completed]: yes manual and new integration test [Risk to taking this patch] (and alternatives if risky): close to null [String changes made]: no

v2.1: https://github.com/mozilla-b2g/gaia/commit/1f2347e26c394d0315718609437eda7807e6a0fa

I am failing this verification due to a similar issue which has been entered as a new bug 1081583. Contact photos/images will disappear and load in slowly when the user scrolls through the list quickly, or cancels a search. Instead of the pictures being lost, they will simply load in slowly. Flame 2.1 KK (319mb) (Full Flash) Device: Flame 2.1 BuildID: 20141010000201 Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1 Gecko: d813d79d3eae Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 34.0a2 (2.1) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

This issue is verified fixed on Flame 2.1 and 2.2. Result: The contact images appears to the user as expected. Device: Flame 2.1 (319mb, KK, Full Flash) BuildID: 20141110001201 Gaia: 0ec1925fc37b7c71d129ae44e42516a0cfb013c4 Gecko: 97487a2d1ee6 Gonk: 48835395daa6a49b281db62c50805bd6ca24077e Version: 34.0 (2.1) Firmware Version: v188-1 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Device: Flame 2.2 (319mb, KK, Full Flash) BuildID: 20141110040206 Gaia: 5f8206bab97cdd7b547cc2c8953cadb2a80a7e11 Gecko: d380166816dd Gonk: 48835395daa6a49b281db62c50805bd6ca24077e Version: 36.0a1 (2.2) Firmware Version: v188-1 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0