Loic Reporter
	Description • 10 years ago

STR: play any MP4 video like http://www.w3schools.com/html/mov_bbb.mp4 and right click to select the entry "save snapshot as".

Result: Nightly fails to open the dialog box to save the snapshot.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 4 • 10 years ago

Comment on attachment 8513781 [details] [diff] [review]
[e10s] Make "Save Snapshot As" context menu item work for e10s. r=?

Grrr, bzexport...

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 5 • 10 years ago

Try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a52dd541eea5

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 7 • 10 years ago

/r/91 - Bug 1067721 - [e10s] Make "Save Snapshot As" context menu item work for e10s. r=?
/r/93 - Regression test

Pull down these commits:

hg pull review -r 734c1b478b5416ddabd116288845f25888148e53

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 8 • 10 years ago

Comment on attachment 8513781 [details] [diff] [review]
[e10s] Make "Save Snapshot As" context menu item work for e10s. r=?

This is the fix I have in mind. The regression test appears to fail on try, so I'm looking into that next.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 12 • 10 years ago

Comment on attachment 8514328 [details] [diff] [review]
Regression test

I re-purposed some pre-existing video support files to do my bidding here, and so I renamed them to be more general.

This test works for both e10s and non-e10s - I was pleasantly surprised that I could use nsIDOMWindowUtils to open a context menu in a framescript.

	:Felipe Gomes (needinfo for replies!)
	Comment 13 • 10 years ago

It's worth checking if you can just use document.popupNode in the child instead of sending back the CPOW ref

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 14 • 10 years ago

(In reply to :Felipe Gomes from comment #13)
> It's worth checking if you can just use document.popupNode in the child
> instead of sending back the CPOW ref

Tried, and it wasn't defined. I can't say I'm 100% surprised though - reading through[1], it looks like document.popupNode is on the outs.

Thanks for the review!

[1]: https://developer.mozilla.org/en-US/docs/Web/API/document.popupNode

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 16 • 10 years ago

Comment on attachment 8514502 [details] [diff] [review]
Regression test

browser_autocomplete_a11y_label.js was relying on that promisePopupHidden bug to actually hide the popup. When I fixed promisePopupHidden, it broke the assumption that promisePopupHidden actually _hides_ the popup (instead of waiting for it to hide). So I just hide the popup here.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 17 • 10 years ago

Thanks!

remote:   https://hg.mozilla.org/integration/fx-team/rev/9ee0da2fce79

	Carsten Book [:Tomcat]
	Comment 18 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/9ee0da2fce79

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 19 • 10 years ago
bugnotes

http://people.mozilla.org/~mconley2/bugnotes/bug-1067721.html

	Cornel Ionce [:noni] [Hubs QA]
	Comment 20 • 10 years ago

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0

Verified fixed on:
- latest Nightly, build ID: 20141228030216
- Firefox 36.0a2, build ID: 20141229004004