Closed
Bug 1067956
Opened 10 years ago
Closed 10 years ago
Async Places Transactions: Drop functionality
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
90% of the work was done elsewhere (see dependency graph). This is just about onDrop.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mano
Comment 1•10 years ago
|
||
Hi Mano, can you provide a point value.
Status: NEW → ASSIGNED
Iteration: --- → 35.2
Flags: qe-verify?
Flags: needinfo?(mano)
Flags: firefox-backlog+
Assignee | ||
Updated•10 years ago
|
Points: --- → 3
Flags: needinfo?(mano)
Updated•10 years ago
|
Flags: qe-verify? → qe-verify-
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8491650 -
Flags: review?(mak77)
Comment 3•10 years ago
|
||
Comment on attachment 8491650 [details] [diff] [review]
patch
Review of attachment 8491650 [details] [diff] [review]:
-----------------------------------------------------------------
similar question to the paste bug, browser_475045.js simulates a drop and soon or later should be fixed to work also with async transactions.
::: browser/components/places/content/controller.js
@@ +1608,5 @@
> let transactions = [];
> let dropCount = dt.mozItemCount;
> let movedCount = 0;
> + let parentGuid = PlacesUIUtils.useAsyncTransactions ?
> + (yield insertionPoint.promiseGuid()) : null;
might we do this yield only in the useAsyncTransactions case below?
I'd not want to change onDrop behavior in the other case, and this is actually making onDrop async.
@@ +1666,5 @@
> + transactions.push(
> + PlacesUIUtils.getTransactionForData(unwrapped,
> + flavor,
> + parentGuid,
> + index, doCopy));
fix indentation
@@ +1671,5 @@
> + }
> + else {
> + transactions.push(PlacesUIUtils.makeTransaction(unwrapped,
> + flavor, insertionPoint.itemId,
> + index, doCopy));
indent 2 more
::: toolkit/components/places/PlacesTransactions.jsm
@@ +335,5 @@
> * @return {Promise}
> + * @resolves either to the resolution of |execute|, in single-transaction
> + * mode, or to the return value of the generator, in generator-mode. For an
> + * array of transactions, there's no resolution value.
> + *
trailing space
Attachment #8491650 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in
before you can comment on or make changes to this bug.
Description
•