e10s is unhappy when hardware acceleration is disabled, e.g. bug 1026521 and bug 1026093. As a temporary workaround, we should add hardware acceleration to our list of conditions that can disable e10s during startup.

This is tricky, since we don't just check a pref for acceleration, we make a lot of last minute decisions in the widget code where we set up composition about turning acceleration on. http://mxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsBaseWidget.cpp#771 http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#3295

Bas, would you mind looking this over? I think I have all the checks I need based on a lot of poking around in widget/gfx code.

I got the sense that this was also (or primarily?) a Mac problem.

Comment on attachment 8490769 [details] [diff] [review] part 1 - win support Review of attachment 8490769 [details] [diff] [review]: ----------------------------------------------------------------- This looks fine, I wonder if there isn't an easier way to detect this, but probably not as early on as this.

(In reply to Bas Schouten (:bas.schouten) from comment #4) > Comment on attachment 8490769 [details] [diff] [review] > patch v.1 > > Review of attachment 8490769 [details] [diff] [review]: > ----------------------------------------------------------------- > > This looks fine, I wonder if there isn't an easier way to detect this, but > probably not as early on as this. Yeah nothing is initialized this early, I was hoping something like gfxPlatform would be but no luck. (In reply to Bill McCloskey (:billm) from comment #3) > I got the sense that this was also (or primarily?) a Mac problem. Ah, thought mac and linux were ok. Working on a mac patch currently on top of this.

(In reply to Jim Mathies [:jimm] from comment #5) > (In reply to Bill McCloskey (:billm) from comment #3) > > I got the sense that this was also (or primarily?) a Mac problem. > > Ah, thought mac and linux were ok. Working on a mac patch currently on top > of this. Mac is affected. See bug 1026093.

- merged to mc tip

Comment on attachment 8490838 [details] [diff] [review] part 2 - add macos support Review of attachment 8490838 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/xre/nsAppRunner.cpp @@ +4568,5 @@ > + SInt32 bugfix = nsCocoaFeatures::OSXVersionBugFix(); > + if (major == 10 && minor == 6 && bugfix <= 2) { > + accelDisabled = true; > + } > +#endif This should be moved into a common helper so we don't accidentally have these two checks diverge.

Comment on attachment 8491058 [details] [diff] [review] macos support Review of attachment 8491058 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/xre/nsAppRunner.cpp @@ +4561,5 @@ > } > } > + > +#if defined(XP_MACOSX) > + // See nsBaseWidget::ComputeShouldAccelerate This comment can go.

I moved it into nsCocoaFeatures.

Comment on attachment 8491064 [details] [diff] [review] part 2 - macos support Review of attachment 8491064 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/xre/nsAppRunner.cpp @@ +4561,5 @@ > } > } > + > +#if defined(XP_MACOSX) > + // See nsBaseWidget::ComputeShouldAccelerate This comment can go.

try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0518fb074e66