Closed Bug 1068225 Opened 10 years ago Closed 10 years ago

Fix up and re-enable assertion in AddonWindowOrNull

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: bholley, Assigned: billm)

References

Details

Attachments

(1 file)

Bill, I'm pretty swamped. Who would be a good person to own this?
Flags: needinfo?(wmccloskey)
Attached patch proto-release-assert (deleted) — Splinter Review
I'll let this sit here for a while while we see how compartment_per_addon goes. Once that feels solid we can land this. I wish there was a way to needinfo my future self, but I guess I'll just leave the flag set.
Assignee: nobody → wmccloskey
Status: NEW → ASSIGNED
Attachment #8490362 - Flags: review?(bobbyholley)
Attachment #8490362 - Flags: review?(bobbyholley) → review+
Stylish 1.4.3 [1] does this fairly consistently for me with E10s, usually when restarting after re-enabling the add-on. That's a fresh profile with just Stylish and E10s enabled. Weirdly, the most consistent crash I can cause is clicking the button to read user reviews in the Add-on Manager. It only happens when Stylish is enabled, but crashes when attempting to read reviews of any add-on. [1] https://addons.mozilla.org/en-US/firefox/addon/stylish/ Respective crash reports: https://crash-stats.mozilla.com/report/index/df93476e-c5f9-44b9-9525-1cf922140916 (Enabling) https://crash-stats.mozilla.com/report/index/da557f00-ada5-44af-a77b-817e92140916 (Reviews)
Summary: Figure out which addons are munging the global prototype and get them to stop → Fix up and re-enable assertion in AddonWindowOrNull
Blocks: 1030420
Flags: needinfo?(wmccloskey)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: