Closed
Bug 1068483
Opened 10 years ago
Closed 10 years ago
Implement reopening a MediaSource after it has been ended
Categories
(Core :: Audio/Video, defect, P5)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: cajbir, Assigned: cajbir)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
This is spun from the test in bug 1064113 comment 8. When a MediaSource is at EndOfStream and an AppendBuffer is done we should get a new 'sourceopen' event and playback can continue.
This used to work as described in bug 1064113 but now fails with an NS_ERROR_FAILURE on the sb.AppendBuffer call that is made after the EndOfStream.
Failure occurs because mCurrentDecoder in TrackBuffer::AppendData is null.
|
Assignee | |
Comment 1•10 years ago
|
||
Attached test fails with NS_ERROR_FAILURE as described in comment 0.
|
|
Assignee | |
Comment 2•10 years ago
|
||
Looks like it failed when 1062657, 1065218 and 1065219 landed. Reverting those results in the test passing.
|
||
Comment 3•10 years ago
|
||
Note that it was only ever (partially) working by accident; reopening a MediaSource after it has been ended has not yet been implemented (per bug 1064113 comment 6).
|
|
Assignee | |
Comment 4•10 years ago
|
||
Renamed bug to be clearer as described in comment 3.
Blocks: MSE
Summary: MSE sb.appendBuffer after an ms.endOfStream fails with NS_ERROR_FAILURE → Implement reopening a MediaSource after it has been ended
|
|
Assignee | |
Comment 5•10 years ago
|
||
Tests the case where a mediasource is in the middle of a seek and an endOfStream occurs. The seek should wait and resume after an appendBuffer containing the required data occurs.
|
|
Assignee | |
Comment 6•10 years ago
|
||
Work in progress fix. Need to identify what to do for MediaSourceReader EOS. Tests attached here pass but running all mediasource tests hang.
Assignee: nobody → cajbir.bugzilla
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 7•10 years ago
|
||
Fixes test shutdown hang.
Attachment #8494205 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•10 years ago
|
||
Currently tests pass except for intermittent failure on test_EndOfStreamAndAppend.html, line 35. This seems to be bug 1065215.
Depends on: 1065215
|
||
Updated•10 years ago
|
Priority: -- → P5
|
||
Comment 9•10 years ago
|
||
This has been fixed by 1120086
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•