Patch Viewer allows one to view patches, which is nice, but it also has CVS, LXR and Bonsai integration. Even Mozilla doesn't use this any more. We should remove it. Gerv

I think I need this bug to be fixed to fully fix bug 1073271.

Actually no, I don't need this bug to fix bug 1073271. But now that I wrote it... :)

Comment on attachment 8504422 [details] [diff] [review] patch, v1 Review of attachment 8504422 [details] [diff] [review]: ----------------------------------------------------------------- I applied the patch and got an error about Bugzilla/Config/PatchViewer.pm not returning a true value. It seems that this patch makes this file empty instead of deleting it. Removing it fixed the problem. If you make sure you actually remove the file when checking in, r=gerv. Gerv

(In reply to Gervase Markham [:gerv] from comment #3) > I applied the patch and got an error about Bugzilla/Config/PatchViewer.pm > not returning a true value. It seems that this patch makes this file empty > instead of deleting it. Removing it fixed the problem. Yes I know. That's what I initially did (removing the file), but then git was unable to include it in the diff (CVS and bzr were both able to do that, so I guess there is a trick with git to do it, but I don't know which one). Don't worry, I will make sure both files are gone. :)

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git 7ce5b04..94ffb7a master -> master

this triggered a warning in t/012throwables.t: # Failed test '--WARNING template/en/default/global/user-error.html.tmpl has 1 unused error tag(s): # user error tag 'invalid_context' is defined at line(s) (1028) but is not used anywhere' To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git 855faaa..a2e5436 5.0 -> 5.0 To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git fa12395..5a1a4b9 master -> master

Added to relnotes for 5.0rc3.