STR: 1. Open Camera 2. Set Flash On/Auto 3. Tap on the capture icon 4. Observed the issue that flash always remain ON after we capture a snapshot Target and build info: Device msm8x26 QRD KK branch Gaia : 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f Gecko: a50444fdaa68fefefc3ecc08d97530e13a4742ab OS Version: 2.1.0 Platform Version : 34.0a2 Build ID: 20140915184008

[Blocking Requested - why for this release]:

QA Wanted - Is this possible to reproduce on a 2.1 KK Flame build?

(In reply to Pooja from comment #0) > 4. Observed the issue that flash always remain ON after we capture a > snapshot Actually see the flash is always ON as soon as we move to auto mode for flash

With Flame KK 2.1, using both the camera app on homescreen and on the lock screen, I'm unable to get the flash light to remain on when switching flash modes and taking pictures. It turns on during photos when it should, then turns off when it should. I see nothing to indicate there is a problem on the Flame device here. 0/20 attempts. Environmental Variables: Device: Flame 2.1 KK BuildID: 20140917073957 Gaia: 47939f4c41d0c941e5047e5d1af74a79b7d8e0d5 Gecko: d7ad9b5167d8 Version: 34.0a2 Firmware Version: L1TC00011650 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Leaving QAWanted for others to try.

No Repro on Flame

I was able to repro this bug on KK Flame 2.1 using a slightly different set of repro steps. STR: 1. Launch the Camera app. 2. Place the camera where it will receive barely any light (eg leaning on the edge of a laptop with the camera lens and flash just above the lip). 3. Take a picture, then wait for about 10 seconds. 4. If the viewfinder remains black, repeat step 3. 5. If the viewfinder flashes white and stays light, pick up the device and observe the state of the camera flash light. BuildID: 20140917092802 Gaia: 987645cd189790e27ceb49497028ed32e8d00c90 Gecko: 9a8082b71c95 Platform Version: 34.0a2 Firmware Version: v165 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Diego, Please investigate based on STR in comment 6 using Flame. Thanks Hema

QA-Wanted tag for a full branch check using STR in comment 6

This doesn't reproduce on gaia master and JB on a Flame device Gaia c7ef0bf06ce1c98cbe68aa52e2ecd862acb23e9c Gecko https://hg.mozilla.org/mozilla-central/rev/53f7f5b6d7bf BuildID 20140922040204 Version 35.0a1 Firmware Version: v123 Justin tried on KK (v180 OEM build) and he's not able to reproduce either. ni him to confirm this.

(In reply to Diego Marcos [:dmarcos] from comment #9) > This doesn't reproduce on gaia master and JB on a Flame device > > Gaia c7ef0bf06ce1c98cbe68aa52e2ecd862acb23e9c > Gecko https://hg.mozilla.org/mozilla-central/rev/53f7f5b6d7bf > BuildID 20140922040204 > Version 35.0a1 > Firmware Version: v123 > > Justin tried on KK (v180 OEM build) and he's not able to reproduce either. > ni him to confirm this. Confirming that I am unable to reproduce on Flame KK v180 running latest master branch (v2.2).

The bug repros on KK Flame 2.2 and Flame 2.1 Actual result: With barely any light available, the flash will turn on and stay on. Flame 2.2 BuildID: 20140923065343 Gaia: 37b8a812c642ca616bf9457cb9b71e45261cdfa8 Gecko: 9e193395b912 Platform Version: 35.0a1 Firmware Version: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Flame 2.1 BuildID: 20140923073140 Gaia: 1e554253d11b0cc932de39c0a4510d1abb176550 Gecko: ee9dbbb02910 Platform Version: 34.0a2 Firmware Version: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 -------------------------------------------------------------------------------------------------------- The bug does not repro on Flame 2.0 Actual result: With barely any light available, the flash will not turn on until the camera button is tapped and a picture is taken. Once the picture is taken, the flash will turn back off and stay off. BuildID: 20140923071344 Gaia: 6449cc35a8f0704d95acac374ba857bde4b86d6c Gecko: f18695cae418 Platform Version: 32.0 Firmware Version: V180 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

In comment 11, it sounds as though you're saying that the flash is turning on and staying on in v2.1 and v2.2 without even tapping the capture button. I'd just like to confirm if that's what you observed.

Yes, the flash can turn on and stay on without tapping the Camera button. After a picture is taken, the flash can turn back on and stay on.

(In reply to Chris Kreinbring [:CKreinbring] from comment #13) > Yes, the flash can turn on and stay on without tapping the Camera button. > After a picture is taken, the flash can turn back on and stay on. I'm going to rename this bug to reflect what you observed then as this may lead to confusion. The current title of the bug makes it sound as though you need to take a picture to observe this behavior.

Confirmed on latest Flame KK (v180 base image) running master (v2.2). Updated STR: 1. Set Flash to "On" or "Auto" 2. Exit Camera app 3. Enter a dark room or dimly-lit area 4. Open Camera app 5. Observe flash turn on and remain lit

In order to retrieve the state of the focus cycle (failed, focused...) we call autoFocus when continuous auto focus (CAF) is moving as stated in the Android documentation: http://developer.android.com/reference/android/hardware/Camera.Parameters.html#FOCUS_MODE_CONTINUOUS_VIDEO In the case of Flame the call to autoFocus seems to be triggering the flash. Everything points to an unexpected driver behavior.

This issue occur on the earliest available Flame KK build and does not occur on builds of the v123 JB base. A regression window cannot be found. Environmental Variables: Device: Flame 2.2 BuildID: 20140904171737 Gaia: de59e0c3614dd0061881fe284e9f2d74fa0d1d5d Gecko: 8703c1895505 Version: 35.0a1 (2.2) Firmware Version: User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

I just r+ed the patch for bug 1068559 and this bug will be fixed as well.

bug 1068559 had landed. Pooja, Can you please try to reproduce again on latest master? This bug should be gone now. Thank you!

Thanks Diego. Patch works. Flash Issue is not reproducible with your patch. But i see that reg bug 1068559 CAF circle always remains white. Earlier it used to turn Green on CAF success and Red on CAF failure. Is it expected with your change?

It's working for me on latest master. The focus ring changes color appropriately on CAF mode. I'm on KK Gaia 77ef35f5429bc3dfe9ca192b9aacc3c0bf8857de Gecko https://hg.mozilla.org/integration/b2g-inbound/rev/b13afdbcf97b BuildID 20140929090301 Version 35.0a1

(In reply to Pooja from comment #21) > Thanks Diego. Patch works. Flash Issue is not reproducible with your patch. > > But i see that reg bug 1068559 CAF circle always remains white. Earlier it > used to turn Green on CAF success and Red on CAF failure. Is it expected > with your change? Pooja, I am not convinced the attached patch will work, but it might be worth a shot to see if it makes a difference. Like Diego I haven't been able to reproduce, but I was never able to hit the original problem either.

Hi Andrew and Diego, We don't have appropriate codebase for master so could not verify this patch on master. I verified patch in bug 1068559 on 2.1. With this 2.1 the original issue is fixed but i am seeing another issue (Both camera and camcorder)i.e CAF circle not going to Green and Red @Andrew Could not compile your attached gecko patch with 2.1. Got error with mOnAutoFocusCompletedCb . Seems it newly introduced in master Need help from you to kindly verify the same patch as in bug 1068559 on v2.1 once. So that we can confirm about new CAF circle issue?

Comment on attachment 8496988 [details] [diff] [review] bug1068528.patch Our master code base is not appropriate. SO could not try this patch on master. And attached patch failed to compile for 2.1 ,due to code differences

HI Andrew and Diego, It is my mistake. I overlooked the gecko patch provided in bug 1068559 With Gaia and gecko patch on bug 1068559 both Flash and CAF issues get resolved. @Andrew : So sadly your attachment 8496988 [details] [diff] [review] not required. Once again I apologies for my mistake :(

Comment on attachment 8496988 [details] [diff] [review] bug1068528.patch (In reply to Pooja from comment #26) > HI Andrew and Diego, > > It is my mistake. I overlooked the gecko patch provided in bug 1068559 > With Gaia and gecko patch on bug 1068559 both Flash and CAF issues get > resolved. > > @Andrew : So sadly your attachment 8496988 [details] [diff] [review] not > required. > > Once again I apologies for my mistake :( No worries, glad to hear it is working :).

This bug has been solved by bug 1068559

This issue has been verified successfully on Flame 2.1 See attachment: Verify_video.3gp Reproducing rate: 0/5 Flame 2.1 version: Gaia-Rev 8ae086c39011bc8842b2a19bb5267906fa22345a Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebbd5c65c3c1 Build-ID 20141124094013 Version 34.0