Pooja Reporter
	Description • 10 years ago

STR:
1. Open Camera
2. Switch to recording
3. Start recording. You will hear a sound, which signifies "recording  
   started"
4. After some duration stop recording
5. Play the recorded video

Actual behavior:
 The "recording started" sound also gets recorded 

Expected behavior:
 Recorded video should not contain "recording started" sound.

Device and build Details:
Device msm8x26 QRD KK branch

Gaia : 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko: a50444fdaa68fefefc3ecc08d97530e13a4742ab
OS Version: 2.1.0
Platform Version : 34.0a2
Build ID: 20140915184008

	Pooja Reporter
	Comment 1 • 10 years ago

[Blocking Requested - why for this release]:

	Jason Smith [:jsmith]
	Comment 2 • 10 years ago

QA Wanted - Does this reproduce on a Flame 2.1 KK build?

	Chris Kreinbring [:CKreinbring]
	Comment 3 • 10 years ago

The bug does not repro on KK Flame 2.2, Flame 2.1, or Flame 2.0
Actual result: The beginning of a recorded video does not contain the device sound for a recording start.

Flame 2.2
BuildID: 20140916133056
Gaia: e2d70bee03b5380ac327a145e5d694fb2443f018
Gecko: 55b46de164d8
Platform Version: 35.0a1
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1
BuildID: 20140917092802
Gaia: 987645cd189790e27ceb49497028ed32e8d00c90
Gecko: 9a8082b71c95
Platform Version: 34.0a2
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0
BuildID: 20140917073857
Gaia: 31434a3949556171f3565ca47ac2b44e810e95e6
Gecko: e02fe140c0d5
Platform Version: 32.0
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

	Hema Koka [:hema]
	Comment 4 • 10 years ago

Blocking Reason: Unnecessary recording sounds also recorded in the video - broken function

This is probably related to setting the right startTimeOffset to add a delay. Is this something that devices team can investigate for QRD with KK build?

NI Vincent to have the right folks added to investigate. Also adding Mike to provide guidance (Note: Mike is out till 9/22)

Thanks
Hema

	Justin D'Arcangelo [:justindarc]
	Comment 5 • 10 years ago

I think this is a dupe of Bug 1013313 -- there are 2 sounds played, one of which is initiated by the camera driver itself

	Vincent Liu[:vliu]
	Comment 6 • 10 years ago

Sorry to late reply. Currently Camera service only expose a command to disable shutter sound for picture mode by CAMERA_CMD_ENABLE_SHUTTER_SOUND. Gecko disables it in 

http://dxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraHwMgr.cpp#182

But for video mode, it doesn't have any API to enable/disable it. Removing the VideoRecord.ogg mentioned in bug 1013313 Comment 9 and let gaia plays the sound seems a good way to go.

	Justin D'Arcangelo [:justindarc]
	Comment 7 • 10 years ago

(In reply to Vincent Liu[:vliu] from comment #6)
> Sorry to late reply. Currently Camera service only expose a command to
> disable shutter sound for picture mode by CAMERA_CMD_ENABLE_SHUTTER_SOUND.
> Gecko disables it in 
> 
> http://dxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraHwMgr.
> cpp#182
> 
> But for video mode, it doesn't have any API to enable/disable it. Removing
> the VideoRecord.ogg mentioned in bug 1013313 Comment 9 and let gaia plays
> the sound seems a good way to go.

This file is part of the Flame base image, right? What do we need to do to get this removed?

	Vincent Liu[:vliu]
	Comment 8 • 10 years ago

(In reply to Justin D'Arcangelo [:justindarc] from comment #7)
> (In reply to Vincent Liu[:vliu] from comment #6)
> > Sorry to late reply. Currently Camera service only expose a command to
> > disable shutter sound for picture mode by CAMERA_CMD_ENABLE_SHUTTER_SOUND.
> > Gecko disables it in 
> > 
> > http://dxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraHwMgr.
> > cpp#182
> > 
> > But for video mode, it doesn't have any API to enable/disable it. Removing
> > the VideoRecord.ogg mentioned in bug 1013313 Comment 9 and let gaia plays
> > the sound seems a good way to go.
> 
> This file is part of the Flame base image, right? What do we need to do to
> get this removed?

Yes, this is part of the Flame base image. I can take care of this part.

	Hema Koka [:hema]
	Comment 9 • 10 years ago

This issue is on QRD (Bug 1013313 is tracking for Flame). Vincent do you or anyone in the devices team have a QRD running KK image where we can reproduce and nail down where the problem is (perhaps QRD also has the same issue as in Flame). NI pooja here to see if that is the case.

	Vincent Liu[:vliu]
	Comment 10 • 10 years ago

As I know Viral may has QRD device. I can check with him when I see him on next Monday. If I got one from him, I can help for this.

	Hema Koka [:hema]
	Comment 11 • 10 years ago

Thanks so much Vincent! I am leaving an NI so you an provide an update.

Thanks
Hema

	Vincent Liu[:vliu]
	Comment 12 • 10 years ago

(In reply to Hema Koka [:hema] from comment #11)
> Thanks so much Vincent! I am leaving an NI so you an provide an update.
> 
> Thanks
> Hema

I tried to sync to last. When I switched to video mode, it seems to crash in libmmcamera2_sensor_modules.so. Does anyone can help on this? 

I/DEBUG   (  200): 
I/DEBUG   (  200): backtrace:
I/DEBUG   (  200):     #00  pc 0000ad5c  /system/vendor/lib/libmmcamera2_sensor_modules.so (eeprom_get_raw_data+3)
I/I/O     (  205): connect failed with error 2 (No such file or directory)
I/DEBUG   (  200):     #01  pc 0000b121  /system/vendor/lib/libmmcamera2_sensor_modules.so
I/DEBUG   (  200):     #02  pc 00004615  /system/vendor/lib/libmmcamera2_sensor_modules.so
I/DEBUG   (  200):     #03  pc 0000431b  /system/vendor/lib/liboemcamera.so
I/Gonk    (  205): RIL[0]: OnConnectError
I/DEBUG   (  200):     #04  pc 00004cd3  /system/vendor/lib/liboemcamera.so
I/Gonk    (  205): RIL[0]: OnDisconnect
I/DEBUG   (  200):     #05  pc 00005307  /system/vendor/lib/liboemcamera.so
I/DEBUG   (  200):     #06  pc 0000673f  /system/vendor/lib/liboemcamera.so
I/I/O     (  205): connect failed with error 2 (No such file or directory)
I/DEBUG   (  200):     #07  pc 0000d228  /system/lib/libc.so (__thread_entry+72)
I/DEBUG   (  200):     #08  pc 0000d3c0  /system/lib/libc.so (pthread_create+240)
I/Gonk    (  205): RIL[0]: OnConnectError
I/Gonk    (  205): RIL[0]: OnDisconnect
I/DEBUG   (  200): 
I/DEBUG   (  200): stack:
I/DEBUG   (  200):          b59d3788  00000003  
I/I/O     (  205): connect failed with error 2 (No such file or directory)
I/DEBUG   (  200):          b59d378c  b6d637dc  /system/vendor/lib/libmmcamera2_sensor_modules.so
I/DEBUG   (  200):          b59d3790  b686dc90  
I/Gonk    (  205): RIL[0]: OnConnectError
I/DEBUG   (  200):          b59d3794  b57b5178  /system/vendor/lib/libchromatix_ov8825_video_hd.so
I/Gonk    (  205): RIL[0]: OnDisconnect
I/DEBUG   (  200):          b59d3798  b72af0f8  [heap]
I/DEBUG   (  200):          b59d379c  b6ef8979  /system/bin/linker
I/DEBUG   (  200):          b59d37a0  00000000  
I/I/O     (  205): connect failed with error 2 (No such file or directory)

	Pooja Reporter
	Comment 13 • 10 years ago

Unfortunately, We are not seeing this issue on latest build :)
"gaia" revision="713448b8963cd53c561f4b38640f8c63b655ce33"
"gecko" revision="395370094caa386ebf8fe8831d030bc5484fa599"

	Hema Koka [:hema]
	Comment 14 • 10 years ago

Thanks Pooja! Fortunately, we can close this as WORKS FOR ME based on your update :) 

Please reopen if you still see any problems. Thanks for testing!