vasanth Reporter
	Description • 10 years ago

[Blocking Requested - why for this release]:

[Blocking Requested - why for this release]:
Blocking CAF FC release

While music playback is going on randomly touch play/pause, next, previous icons.
Sometimes input events are not recognized 100%.
In those cases, playback doesn't change and icons keep highlighting.

Able to reproduce with some effort. Repeatedly press the music app icons with 0.5-1 second delay. Once reproduced, next time it comes very easily.
See attached video.

I checked |adb shell getevent| shows proper events in failure cases, hence the issue could be in gecko.

Note:
Able to reproduce with offload and non offload audio playback

	Jason Smith [:jsmith]
	Comment 2 • 10 years ago

QA Wanted - Can we reproduce this on a 2.1 KK Flame build?

	Cody Roesch [:croesch]
	Comment 3 • 10 years ago

I've been able to reproduce this issue in Flame 2.1 KK. Attached screenshot of the Rewind button retaining a highlight even though the music is playing.

Repro Rate: 5/25

Environmental Variables:
Device: Flame Master
BuildID: 20140917073957
Gaia: 47939f4c41d0c941e5047e5d1af74a79b7d8e0d5
Gecko: d7ad9b5167d8
Version: 34.0a2 (Master) 
Firmware Version: L1TC00011650
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

	Cody Roesch [:croesch]
	Comment 5 • 10 years ago

The build info says master but it is not master that should have been removed. It's Flame 2.1.

	Joshua Mitchell (Inactive)
	Comment 6 • 10 years ago

Repro's in Flame - QA-Wanted for full branch check

	Cody Roesch [:croesch]
	Comment 7 • 10 years ago

This bug repro's on Flame KK builds: Flame 2.2, Flame 2.1, Flame 2.0, Flame 1.4  OpenC 2.2

Actual Results: Able to get music buttons to remain highlighted when they should not.

Repro Rate: 7/7

Environmental Variables:
Device: Flame Master KK
BuildID: 20140917212258
Gaia: d37950eb09e28aa18d0e01df9ff90574bd4337e0
Gecko: 426497473505
Version: 35.0a1 (Master) 
Firmware Version: L1TC00011650
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20140918073020
Gaia: 379e68fe729a684fa2fcddb30ea1e65508db73e1
Gecko: 44eec4673c25
Version: 34.0a2
Firmware Version: L1TC00011650
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20140918082321
Gaia: 31434a3949556171f3565ca47ac2b44e810e95e6
Gecko: 5cf783171d5c
Version: 32.0 (2.0) 
Firmware Version: L1TC00011650
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 1.4 KK
BuildID: 20140814202332
Gaia: 129211661489feb60bbd6772a44081d23b374f17
Gecko: 
Version: 30.0 (1.4)
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
-----------------------------------------------------------------
Device: Open_C 2.2
BuildID: 20140917212258
Gaia: d37950eb09e28aa18d0e01df9ff90574bd4337e0
Gecko: 426497473505
Version: 35.0a1 (2.2)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

	howie [:howie]
	Comment 8 • 10 years ago

Hi Vivien, can you help to take a look? This seems like a Gecko issue, thanks.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 9 • 10 years ago

This is not a input management bug. Input management is explicitly about management of input/keyboard app. Read the desc!

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 10 • 10 years ago

This seems like a APZ / Highlighting issue. This code use to lives into BrowserElementPanning.js, but has moved into the Gecko APZ side since a few monthes. Let's needinfo the people that knows this code :)

	Doug Sherk (:drs) (inactive)
	Comment 11 • 10 years ago

I've been out of APZ for a while, so it's probably better for Botond to investigate this.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 12 • 10 years ago

We have a number of issues with highlighting and :active elements. UX has yet to provide us with a spec as to how this is supposed to work with multitouch and various edge cases. See bug 1014322 and bug 1009684.

	Dietrich Ayala (:dietrich)
	Comment 13 • 10 years ago

Triage group decided blocking+ due to commercialization requirement.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 14 • 10 years ago

Based on the log I gathered I think what's going wrong here is that the last tap is disallowed in the code, presumably because the first tap (which included some move events) induced a velocity in the APZ, even though it wasn't actually pannable.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 15 • 10 years ago

The DiallowSingleTap code was getting erroneously triggered because of leftover velocity from the previous tap. Clearing it out fixes the issue.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 16 • 10 years ago

This particular issue is a regression from bug 1039979 and should only affect 2.1 and up. There may be a different root cause in 2.0 and older versions. Since this bug is conveniently blocking-b2g: 2.1+ I can uplift the fix to 2.1 and ignore the older versions.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 17 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/40c2c60d7666

	Ryan VanderMeulen [:RyanVM]
	Comment 18 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/40c2c60d7666

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 19 • 10 years ago

Comment on attachment 8498319 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: unsure. the root cause on 2.0 and earlier is probably different than on 2.1+ since the code changed significantly in 2.1
[User impact if declined]: in some cases doing a tap on an item will not actually dispatch a click to the item, and will leave the item in a highlighted state. This generally happens on non-scrollable elements if the previous tap included some small velocity component
[Describe test coverage new/current, TBPL]: local testing
[Risks and why]: low-risk, affects APZ platforms (B2G/Metro) only.
[String/UUID change made/needed]: none

	bhavana bajaj [:bajaj]
	Comment 21 • 10 years ago

Comment on attachment 8498319 [details] [diff] [review]
Patch

Approving and requesting some QA verification/testing once this lands on 2.1

	Ryan VanderMeulen [:RyanVM]
	Comment 22 • 10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/604d60489865

	Tony Chung [:tchung]
	Comment 23 • 10 years ago

please verify this is fixed against master and 2.1 next build.

	Joshua Mitchell (Inactive)
	Comment 24 • 10 years ago

Verified Fixed on Master and 2.1

actual results: Music app icons/buttons do not remain highlighted

Environmental Variables:
Device: Flame Master
Build ID: 20141007130518
Gaia: 9050edcda308b65d86577c8ed0eedc5c568d8e44
Gecko: 0c8ae792f1c0
Version: 35.0a1 (Master)
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
Build ID: 20141007075118
Gaia: da328c6cbabf2cffc2d362e282cacc93325d1f43
Gecko: aebe54593d60
Version: 34.0a2 
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

	vasanth Reporter
	Comment 25 • 10 years ago

This issue was fixed for some days and now it is reproduced again with the below Gaia/Gecko sha1s
gaia f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
gecko db7fce920e7d782d9f601384dc95924abcdaeeb8

COuld you please try the same STR in latest builds?

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 26 • 10 years ago

Please file a new bug for the issue you are seeing with complete STR.