Closed Bug 1068621 Opened 10 years ago Closed 10 years ago

Tab Mix Plus addon breaks nightly's layout catastrophically: TypeError: redeclaration of variable; TypeError: Tabmix.initialization is undefined

Categories

(WebExtensions :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jdm, Unassigned)

References

Details

(Keywords: regression)

When I enable Tab Mix Plus on Nightly, the browser is completely broken after startup. The tab bar appears in the wrong place, containing one tab with no text, and no page content loads. The only way to fix it is to start in safe mode and disable Tab Mix Plus for future sessions; I haven't figured out how to obtain browser console output to figure out what's breaking, unfortunately.
Component: Tabbed Browser → Extension Compatibility
did you have enabled e10s?
Flags: needinfo?(josh)
No.
Flags: needinfo?(josh)
Please report this to the add-on author.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Tab Mix Plus is #21 on AMO's top add-ons, installed by more than 1.1M users. Their Firefox experience will be totally broken. This was a regression from bug 1001090 (ES6 "temporal dead zone" for `let`) in Nightly 35 build 2014-09-16: > JavaScript error: chrome://tabmixplus/content/tabmix.js, line 1048: TypeError: redeclaration of variable cwb > JavaScript error: chrome://tabmixplus/content/click/click.js, line 946: TypeError: redeclaration of variable count > JavaScript strict warning: chrome://tabmixplus/content/tab/tabbrowser_4.xml, line 453: ReferenceError: reference to undefined property Tabmix.initialization > JavaScript error: chrome://tabmixplus/content/tab/tabbrowser_4.xml, line 453: TypeError: Tabmix.initialization is undefined > JavaScript strict warning: chrome://tabmixplus/content/links/setup.js, line 52: ReferenceError: reference to undefined property Tabmix.initialization > JavaScript error: chrome://tabmixplus/content/links/setup.js, line 52: TypeError: Tabmix.initialization is undefined
Blocks: 1001090
Keywords: regression
Summary: Tab Mix Plus breaks nightly's layout catastrophically → Tab Mix Plus addon breaks nightly's layout catastrophically: TypeError: redeclaration of variable; TypeError: Tabmix.initialization is undefined
(In reply to Dão Gottwald [:dao] from comment #3) > Please report this to the add-on author. This isn't invalid, it should be put in tech evang.
Status: RESOLVED → REOPENED
Component: Extension Compatibility → Add-ons
Product: Firefox → Tech Evangelism
Resolution: INVALID → ---
Version: unspecified → Trunk
Status: REOPENED → NEW
Tab Mix Plus development build work without any problem! I'v fixed the "redeclaration of variable" errors on the same day bug 1001090 was out. Remember to always use the latest development version available when using Firefox pre-release versions, let it be Beta, Aurora or Nightly.
(In reply to Ed Morley [:edmorley] from comment #5) > (In reply to Dão Gottwald [:dao] from comment #3) > > Please report this to the add-on author. > > This isn't invalid, it should be put in tech evang. No need to evangelize, as onemen usually stays on top of recent developments. And when he doesn't, there are direct feedback channels that should be used. From the TechEvang / Add-ons description: "Note that ordinary add-on bugs should not be filed here, but should be filed with the add-on's own bug tracker."
Status: NEW → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → INVALID
(In reply to Dão Gottwald [:dao] from comment #7) > From the TechEvang / Add-ons description: "Note that > ordinary add-on bugs should not be filed here, but should be filed with the > add-on's own bug tracker." I had not seen that, thank you :-) That said, given now comment 6, a clearer status would be fixed.
Resolution: INVALID → FIXED
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
You need to log in before you can comment on or make changes to this bug.