There's a bunch of legacy warts in the Talos code which would be nice to clean up.

yeah, there is a lot of it. It would be nice to clean up the e10s stuff in pageloader.js and related bits. I suspect some of it is unnecessary now.

This patch was automatically generated via reindent.py, so it should just work.

Mostly just unused variables, but a few real errors did come up. I imagine they're not serious since they're not actively causing problems, but might as well fix them.

(In reply to Joel Maher (:jmaher) from comment #1) > yeah, there is a lot of it. It would be nice to clean up the e10s stuff in > pageloader.js and related bits. I suspect some of it is unnecessary now. Yup, I'm just focusing on the python stuff here but we probably do indeed want to clean up the e10s stuff just after it lands, since it's still fresh in our minds.

Comment on attachment 8490959 [details] [diff] [review] Reindent to 4 spacing everywhere Review of attachment 8490959 [details] [diff] [review]: ----------------------------------------------------------------- oh lots of changes.

Comment on attachment 8490960 [details] [diff] [review] Fix pyflakes nits Review of attachment 8490960 [details] [diff] [review]: ----------------------------------------------------------------- ::: talos/PerfConfigurator.py @@ +582,1 @@ > self.config['extensions'] = ['${talos}/mobile_extensions/roboextender@mozilla.org'] Is this the only place in perfconfigurator.py where test is used as a variable?

(In reply to Joel Maher (:jmaher) from comment #8) > Comment on attachment 8490960 [details] [diff] [review] > Fix pyflakes nits > > Review of attachment 8490960 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: talos/PerfConfigurator.py > @@ +582,1 @@ > > self.config['extensions'] = ['${talos}/mobile_extensions/roboextender@mozilla.org'] > > Is this the only place in perfconfigurator.py where test is used as a > variable? Yes, elsewhere we're just using the module.

Did a try run for all this stuff, it looks good: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=101f2cfcc4ce Landed: https://hg.mozilla.org/build/talos/rev/57a1b4d87e48 https://hg.mozilla.org/build/talos/rev/788139c327ee https://hg.mozilla.org/build/talos/rev/62d66045c167 https://hg.mozilla.org/build/talos/rev/cb9c815dfcbc (note that we need to update m-c for these changes to take effect, but there's no point, since they should have no effect on talos itself)