Eitan Isaacson [:eeejay] Reporter
	Description • 10 years ago

This may be a screen reader bug, but tracking it here.

When the user activates the flash button, you should hear "flash on" or "flash off". Alternatively, it could be a tri-state toggle button disabled=off, enabled=on, mixed=auto.

	Eitan Isaacson [:eeejay] Reporter
	Comment 1 • 10 years ago

Same with choosing front/back camera.

	Wilson Page [:wilsonpage]
	Comment 3 • 10 years ago

Comment on attachment 8571568 [details]
[gaia] yzen:bug-1068878 > mozilla-b2g:master

Comments on pull-request.

Overall: cool! :)

But I think we need to find a most robust way of mapping modes to `data-l10n-id` attributes. Someone could easily change the icon used and unknowingly break this feature.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 4 • 10 years ago

Comment on attachment 8571568 [details]
[gaia] yzen:bug-1068878 > mozilla-b2g:master

Hopefully all comments addressed.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 6 • 10 years ago

Comment on attachment 8571568 [details]
[gaia] yzen:bug-1068878 > mozilla-b2g:master

Since Wilson is on PTO, asking Justin for a review.

	Justin D'Arcangelo [:justindarc]
	Comment 7 • 10 years ago

Comment on attachment 8571568 [details]
[gaia] yzen:bug-1068878 > mozilla-b2g:master

LGTM

	GitHub Autolander Bot
	Comment 8 • 10 years ago

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5800b7e2d088f0f39f1d0bc4ada99426ca7521bb

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 9 • 10 years ago

Comment on attachment 8571568 [details]
[gaia] yzen:bug-1068878 > mozilla-b2g:master

[Approval Request Comment] This PR makes camera app top menu buttons accessible.
[Bug caused by] (feature/regressing bug #): improvements not a bug
[User impact] if declined: if declined the top menu buttons will be inaccessible to the screen reader users.
[Testing completed]: unit tests + on device
[Risk to taking this patch] (and alternatives if risky): fairly low, mostly changes to accessibility related DOM
[String changes made]: https://github.com/mozilla-b2g/gaia/pull/28574/files#diff-e4bc27afcad6f10d1abaf8eced7aa340

	Francesco Lodolo [:flod]
	Comment 10 • 10 years ago

If you plan to land strings on 2.2, please mark the bugs as late-l10n at this point.

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 10 years ago

v2.2: https://github.com/mozilla-b2g/gaia/commit/3a56340fbf471c669ab425864ca1ddf02b15884c

	Shally Li（leave from Mozilla）
	Comment 12 • 9 years ago

This bug has been verified as "pass" on latest Nightly build of Flame v2.2&3.0 by the STR in Comment 0.

Actual results: After enabling screen reader and opening camera app, the Front camera /Rear camera /Flash on /Flash Off /Flash Auto /Menu button are accessible to the screen reader users.
See attachment: verified_v2.2&3.0.3gp
Reproduce rate: 0/10


Device: Flame v2.2 build(Verified) 
Build ID               20150628002505
Gaia Revision          0179935627012dfde3ca036c9a71035be463b7ad
Gaia Date              2015-06-26 21:13:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/35e09270da3a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150628.035537
Firmware Date          Sun Jun 28 03:55:48 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v3.0 build(Verified)
Build ID               20150629134017
Gaia Revision          27fe0f4261e3685187769411f2f74cff19287b19
Gaia Date              2015-06-29 14:29:00
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c26dbd63604d
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150629.170951
Firmware Date          Mon Jun 29 17:10:03 EDT 2015
Bootloader             L1TC000118D0