Eitan Isaacson [:eeejay] Assignee
	Description • 10 years ago

The image is not accessible. Exploring by touch in the center of the screen gives nothing. We should at least let the user know something is there.

	Eitan Isaacson [:eeejay] Assignee
	Comment 1 • 10 years ago

Straightforward. I checked, and the label changes when the language changes, yes :)

	Punam Dahiya [:pdahiya]
	Comment 2 • 10 years ago

Comment on attachment 8556765 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27798

Looks good. Thanks!

	Eitan Isaacson [:eeejay] Assignee
	Comment 3 • 10 years ago

https://github.com/mozilla-b2g/gaia/commit/af0889dfa344925a945099e65ec8ad73756cb26c

The try run is extremely red, but it is such a simple change that I am betting on some infrastructure breakage.

	Eitan Isaacson [:eeejay] Assignee
	Comment 4 • 10 years ago

Comment on attachment 8556765 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27798

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Screen reader users will not have an indication where the edit preview is.
[Testing completed]: Gaia master is green, and did manual testing.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: Added a string to gallery app.

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 10 years ago

v2.2: https://github.com/mozilla-b2g/gaia/commit/4be3ed76086856759a3b832603ea9d4d3e27c604

	Stefan Plewako [:stef]
	Comment 6 • 10 years ago

What the heck "Edit image preview" is?

	Eitan Isaacson [:eeejay] Assignee
	Comment 7 • 10 years ago

(In reply to Stefan Plewako [:stef] from comment #6)
> What the heck "Edit image preview" is?

It is the image in the center of the screen that changes when you apply effects and edit it. This label is mostly for blind users, so they know what their finger is over when they use a screen reader.

	Stefan Plewako [:stef]
	Comment 8 • 10 years ago

(In reply to Eitan Isaacson [:eeejay] from comment #7)
> It is the image in the center of the screen that changes when you apply
> effects and edit it. This label is mostly for blind users, so they know what
> their finger is over when they use a screen reader.

So this really refers "Edited image preview area" and not "Edit image preview"?

	Eitan Isaacson [:eeejay] Assignee
	Comment 9 • 10 years ago

(In reply to Stefan Plewako [:stef] from comment #8)
> (In reply to Eitan Isaacson [:eeejay] from comment #7)
> > It is the image in the center of the screen that changes when you apply
> > effects and edit it. This label is mostly for blind users, so they know what
> > their finger is over when they use a screen reader.
> 
> So this really refers "Edited image preview area" and not "Edit image
> preview"?

Or really just "preview area" since the name of the screen is titled "edit".