Closed
Bug 1069004
Opened 10 years ago
Closed 10 years ago
Edit view: brightness slider is not accessible
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S6 (20feb)
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1])
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
pdahiya
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details |
(deleted),
image/png
|
Details |
The slider is a bunch of labels, it should be unified to a widget that is perceivable and operable by a screen reader user.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → eitan
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8554063 -
Flags: review?(pdahiya)
Comment 2•10 years ago
|
||
Comment on attachment 8554063 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27649
Hi Eitan
The aria-value attributes part of the patch looks good, however I am not confident reviewing keypress handler for slider. Please see my query in github and set the review flag again with your inputs. Thanks!
Attachment #8554063 -
Flags: review?(pdahiya)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8554063 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27649
Addressed question in PR.
Attachment #8554063 -
Flags: review?(pdahiya)
Comment 4•10 years ago
|
||
Hi Eitan
Please confirm if you are able to test screen reader swipe up and down gesture on slider. It still doesn't works for me on latest m-c Flame-kk. A nit noted in github to add comment explaining key up/down. Thanks!
Updated•10 years ago
|
Flags: needinfo?(eitan)
Assignee | ||
Comment 5•10 years ago
|
||
Yes! You can test this now both with m-c and gecko37.
Flags: needinfo?(eitan)
Comment 6•10 years ago
|
||
Tried on m-c with today's build 20150217074221, flame-kk , accessibility experience has definitely improved but I still fail to use swipe up and down gesture on slider. Attaching screenshot of exposure slider screen with a yellow highlight shown on touching slider. However navigating up and down both on the yellow highlight and slider fails to change the value.
If it helps, please let me know and I can attach video of the experience seen. Thanks
Flags: needinfo?(eitan)
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
I tested this with m-c gecko and master gaia:
https://www.dropbox.com/s/z92sfqhtql1wk2q/2015-02-18%2018.33.20.mp4?dl=0
Flags: needinfo?(eitan)
Comment 9•10 years ago
|
||
Comment on attachment 8554063 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27649
Thanks Eitan for uploading video, it helps a lot and I am able to use slider with screen reader enabled. I guess the key is to do it slow and give gesture enough time so that it doesn't change focus to preview image.
Please add comment explaining screen reader slider swipe up and down code and it's good to land.
Attachment #8554063 -
Flags: review?(pdahiya) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8554063 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27649
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Brightness slider won't be accessible to screen reader users.
[Testing completed]: Yes, this has been on master for a while.
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]: None.
Attachment #8554063 -
Flags: approval-gaia-v2.2?
Updated•10 years ago
|
Attachment #8554063 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 12•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•