Closed Bug 1069376 Opened 10 years ago Closed 10 years ago

Using SeaMonkey cannot expand developer's comments and version sections

Categories

(addons.mozilla.org Graveyard :: Code Quality, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
2014-10

People

(Reporter: philip.chee, Assigned: davidbgk)

References

Details

STR: 1. Install a SeaMonkey nightly build (or build it yourself) 2. Visit addons.mozilla.org 3. Visit an extension or theme page e.g. https://addons.mozilla.org/en-us/seamonkey/addon/reminderfox/?src=hp-dl-featured 4. Notice that the Developer's Comments section and the Versions section cannot be expanded. Also no review comments show.
Is this problem only happening on nightly builds? I tried with release and didn't see any problems. Are there any errors in the console?
(In reply to Jorge Villalobos [:jorgev] from comment #1) > Is this problem only happening on nightly builds? I tried with release and > didn't see any problems. Happens with SeaMonkey nightly builds AND Thunderbird daily builds. STR for Thunderbird: 1. Go Tools->Add-ons 2. Select Get Addons tab 3. Pick any addon and click on Learn more button 4. New content tab opens e.g Simple Locale Switcher 0.8.3 > > Are there any errors in the console? Sat Sep 27 2014 23:42:57 Error: TypeError: $(...).installButton is not a function Source file: https://addons.cdn.mozilla.net/static/js/impala-min.js?build=16ac44a-54257430 Line: 1 ---------- Sat Sep 27 2014 23:42:57 Error: TypeError: z.button is undefined Source file: https://addons.mozilla.org/en-US/firefox/addons/buttons.js?b=16ac44a-54257430 Line: 14 ---------- Sat Sep 27 2014 23:42:57 Error: www.paypalobjects.com : server does not support RFC 5746, see CVE-2009-3555
The problem seems to be this line in capabilities.js: 'webApps': !!(navigator.mozApps && navigator.mozApps.install), We shouldn't even need that capability check anymore. Let's just remove it.
Severity: normal → critical
Priority: -- → P1
(the same goes for the other mozApps property checks in the same file, of course)
Please add a target milestone on critical bugs given that we use that filter to know which bugs we should work on that month.
Assignee: nobody → david
Target Milestone: --- → 2014-10
I tried to fix this in https://github.com/mozilla/olympia/pull/317 by removing all webApps/app_runtime references and logic but I don't know how to test that i.e. make my Thunderbird opening a local URL instead of directly the AMO prod.
It looks like the only easy way to test this on Thunderbird is to open about:config (Tools > Options > Advanced > Config Editor) and change the 'extensions.webservice.discoverURL' preference to the exact URL you want to visit, and then open the add-ons manager. Unfortunately, the URL filter is hard coded to 'addons.mozilla.org' in Thunderbird, so you won't be able to open any links in Thunderbird.
Depends on: 1080145
I tried to reproduce this issue on thunderbird, but: 1/ it only seems to happens on the very first click on the "read more" link for an extension, and it also happens with the latest public version 31.1.2 2/ i wasn't able to replay this locally by modifying the discoverURL Regarding 2/, you are right Kris, when I click on a link, it opens it in firefox, and there's no issue. I thus don't know how to validate that the fix is working.
Thanks to someone from #thunderbird, I could reproduce this issue locally after installing and using the following extension: https://addons.mozilla.org/en-US/thunderbird/addon/webapp-tabs/?src=search
Testing on Thunderbird 31.1.2, with and without the changes from the PR. The only error I can see atm is on line 204 of zamboni/button.js. It seems it's the ("InstallTrigger" in window) test that raises: NS_ERROR_FACTORY_NOT_REGISTERED. I can't find why this is happening (it looks more like a thunderbird issue?), and if I remove this check, then the page seems to load everytime perfectly. Any clue who I should NI for more information on that?
Depends on: 1081190
After some more investigation and some help from :irving on #thunderbird, it seems this is because of https://bugzilla.mozilla.org/show_bug.cgi?id=1081190 I've updated the PR to "try/catch" around this statement, as a workaround.
Flags: needinfo?(irving)
Depends on: 1019021
Oh, sorry, didn't mean to NI :irving.
Flags: needinfo?(irving)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Confirmed fixed using: User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 SeaMonkey/2.33a1 Build identifier: 20141024233150 Thanks everyone!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.