Closed
Bug 1069521
Opened 10 years ago
Closed 10 years ago
(Settings) Keyboard Settings is using the wrong styles & has a terrible transition
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S5 (26sep)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | fixed |
People
(Reporter: padamczyk, Assigned: rudyl)
References
Details
(Whiteboard: [p=1])
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
text/x-github-pull-request
|
timdream
:
review+
Omega
:
ui-review+
|
Details |
1. Go to Settings > Keyboards
2. See screenshot, it looks to be using the refreshed styles
3. Click on "Built-in Keyboard"
4. See screenshot, it looks like its using the v.1 styles, and the status bar is black not gray.
To Do:
1. Update the "Built-in Keyboard" style to match the refreshed visuals
2. When you click back in the "Built-in Keyboard" the transition is incorrect. The screen should slide from the left edge but it slides from the right edge.
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Hey Carol,
can you provide me the spec for this screen?
Flags: needinfo?(chuang)
Comment 3•10 years ago
|
||
Helen,
Could you take a look at this one?
Thank you!
Flags: needinfo?(chuang) → needinfo?(hhuang)
Comment 4•10 years ago
|
||
Hi Omega,
Please take a look at this one, thank you!!
Flags: needinfo?(hhuang) → needinfo?(ofeng)
Comment 5•10 years ago
|
||
Hi Rudy,
Please help change the status bar color of Built-in Keyboard to gray like Settings. (BTW, the header title is Built-in Keyboard, not Keyboard settings.)
And, I know we cannot fix the transition direction issue now, but could you have some comments on when we can do that? Thanks a lot!
Flags: needinfo?(ofeng) → needinfo?(rlu)
Assignee | ||
Comment 6•10 years ago
|
||
The transition issue could be tracked by bug 1023046.
This bug could be used to track the polishing work mentioned in comment 5.
Flags: needinfo?(rlu)
Assignee | ||
Comment 7•10 years ago
|
||
Pavel, may I know if you have started working on this or need me to take over?
Thanks.
Flags: needinfo?(pivanov)
Comment 8•10 years ago
|
||
Hey Rudy,
if you have time :) feel free to get this one
Flags: needinfo?(pivanov)
Assignee | ||
Comment 9•10 years ago
|
||
Sure, take it.
Assignee: pivanov → rlu
Component: Gaia::Settings → Gaia::Keyboard
Whiteboard: [p=1]
Assignee | ||
Comment 10•10 years ago
|
||
This is a simple patch to handle the following 2 issues:
- Change the status bar color to sync with settings app.
- Modify the title to keyboard app name.
Tim, could you please help review this?
Thanks.
Attachment #8495071 -
Flags: review?(timdream)
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8495071 [details]
Patch V1
Also ask for Omega's help to take a look in case any other parts need to be addressed.
Thank you.
Attachment #8495071 -
Flags: ui-review?(ofeng)
Comment 12•10 years ago
|
||
Comment on attachment 8495071 [details]
Patch V1
I don't think you need JS here, simply
<title data-l10n-id="title">Keyboard</title>
Will do the trick.
Attachment #8495071 -
Flags: review?(timdream) → review-
Comment 13•10 years ago
|
||
Comment on attachment 8495071 [details]
Patch V1
LGTM, thanks!
Attachment #8495071 -
Flags: ui-review?(ofeng) → ui-review+
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8495071 [details]
Patch V1
Sorry that did not realize this should have a much easier way to achieve this.
Could you please review it again?
Attachment #8495071 -
Flags: review- → review?(timdream)
Updated•10 years ago
|
Attachment #8495071 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 15•10 years ago
|
||
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/4bd0fdfeec6cda58c8d25ce69bc3810e8edfa0b1
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•