Closed
Bug 1069588
Opened 10 years ago
Closed 10 years ago
[AccessFu] Collapsed combobox options are spoken in some views
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: eeejay, Assigned: yzen)
References
Details
(Whiteboard: [b2ga11y p=1])
Attachments
(1 file)
(deleted),
patch
|
eeejay
:
review+
|
Details | Diff | Splinter Review |
Specifically in the calendar add event dialog in gaia.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8508456 -
Flags: review?(eitan)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8508456 [details] [diff] [review] 1069588 patch v1 Review of attachment 8508456 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, aside from some things below. A test with a labeled combobox would be good too. ::: accessible/jsat/OutputGenerator.jsm @@ +255,5 @@ > 'pushbutton': INCLUDE_DESC | NAME_FROM_SUBTREE_RULE, > 'checkbutton': INCLUDE_DESC | NAME_FROM_SUBTREE_RULE, > 'radiobutton': INCLUDE_DESC | NAME_FROM_SUBTREE_RULE, > 'buttondropdown': NAME_FROM_SUBTREE_RULE, > + 'combobox': INCLUDE_DESC | INCLUDE_VALUE, Why the change in this line? You are still including the value, no? (I realize it doesn't matter because you have a custom function). ::: accessible/tests/mochitest/jsat/test_output.html @@ +613,5 @@ > <li id="gridcell3" aria-selected="true" role="gridcell">5</li> > <li role="gridcell">6</li> > </ol> > </section> > + <select id="frequency"> I think it would be interesting to have a test for a labeled combobox as well, and see that the name and value are uttered well. @@ +614,5 @@ > <li role="gridcell">6</li> > </ol> > </section> > + <select id="frequency"> > + <option id="selected-combobox-option" value="15">15 min</option> Is this implicitly selected because it is index 0? Maybe add a selected attribute for it to be explicit.
Attachment #8508456 -
Flags: review?(eitan) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Eitan Isaacson [:eeejay] from comment #2) > Comment on attachment 8508456 [details] [diff] [review] > 1069588 patch v1 > > Review of attachment 8508456 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good, aside from some things below. A test with a labeled combobox > would be good too. > > ::: accessible/jsat/OutputGenerator.jsm > @@ +255,5 @@ > > 'pushbutton': INCLUDE_DESC | NAME_FROM_SUBTREE_RULE, > > 'checkbutton': INCLUDE_DESC | NAME_FROM_SUBTREE_RULE, > > 'radiobutton': INCLUDE_DESC | NAME_FROM_SUBTREE_RULE, > > 'buttondropdown': NAME_FROM_SUBTREE_RULE, > > + 'combobox': INCLUDE_DESC | INCLUDE_VALUE, > > Why the change in this line? You are still including the value, no? (I > realize it doesn't matter because you have a custom function). > So I still need it because I do not want the sub-tree to be included when combobox is uttered (If there's no value it will still be included).
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/48d9ab7e03c9
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/48d9ab7e03c9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•