Closed
Bug 1069605
Opened 10 years ago
Closed 10 years ago
Fixes for Settings API race condition errors
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
2.1 S5 (26sep)
People
(Reporter: qdot, Assigned: qdot)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
(deleted),
patch
|
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Continuation of bug 1068962.
There were two patches in bug 1068962 that were not as important to land as the others, and one of them caused a Mnw failure. This bug will continue work on figure out how/why that happened and get them landed without blocking bug 1068962 from landing and fixing eideticker/CI work.
Assignee | ||
Comment 1•10 years ago
|
||
Ben already reviewed this patch in bug 1068962, but it may be causing Mnw failures. Checking here before landing.
Assignee | ||
Comment 2•10 years ago
|
||
Ben already reviewed this patch in bug 1068962, but it may be causing Mnw failures. Checking here before landing.
Assignee | ||
Comment 3•10 years ago
|
||
Now everything passes. With no changes. No idea why.
https://tbpl.mozilla.org/?tree=Try&rev=111fd93f30f3
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8491802 [details] [diff] [review]
Patch 2 (v2) - Only send messages in SettingsLocks when window is live; r=bent
Approval Request Comment
[Feature/regressing bug #]: Bug 900551
[User impact if declined]: Weird error messages if apps close while having messages queued to run.
[Describe test coverage new/current, TBPL]: tbpl logs, b2gperf runs
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8491802 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8491804 [details] [diff] [review]
Patch 3 (v1) - Make sure settings lock exists before trying to remove it; r=bent
Approval Request Comment
[Feature/regressing bug #]: Bug 900551
[User impact if declined]: Weird error messages if apps close while having messages queued to run.
[Describe test coverage new/current, TBPL]: tbpl logs, b2gperf runs
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8491804 -
Flags: approval-mozilla-aurora?
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba79aa341f34
https://hg.mozilla.org/mozilla-central/rev/674e62d19031
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8491802 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
Attachment #8491804 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a7ad950df755
https://hg.mozilla.org/releases/mozilla-aurora/rev/a42a0e6d65fa
You need to log in
before you can comment on or make changes to this bug.
Description
•