Closed Bug 1069617 Opened 10 years ago Closed 10 years ago

Playlist/artist/albums/songs items are not a proper and operable list.

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
2.2 S8 (20mar)
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: yzen, Assigned: eeejay)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1])

Attachments

(2 files, 1 obsolete file)

Depending on the tab panel open in the music app, the lists that are displayed there should have proper semantics and well operable. They are not at the moment.
Assignee: nobody → eitan
Attachment #8563021 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8563021 [details] [gaia] eeejay:bug-1069617 > mozilla-b2g:master r- for now, but only because I have some questions on GitHub. Dominic might be a better person to look at this anyway, since I think he knows more about this part of the code.
Attachment #8563021 - Flags: review?(squibblyflabbetydoo) → review-
Comment on attachment 8563021 [details] [gaia] eeejay:bug-1069617 > mozilla-b2g:master Gave some clarifications in the pull request, and flagging Dominic for review.
Attachment #8563021 - Flags: review- → review?(dkuo)
Comment on attachment 8563021 [details] [gaia] eeejay:bug-1069617 > mozilla-b2g:master eeejay, the patch looks good with one minor issue, please see github for detail.
Attachment #8563021 - Flags: review?(dkuo) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8563021 [details] [gaia] eeejay:bug-1069617 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Screen reader users won't be able to operate all the lists in the music app. [Testing completed]: Yes. [Risk to taking this patch] (and alternatives if risky): Low. [String changes made]: No.
Attachment #8563021 - Flags: approval-gaia-v2.2?
Attachment #8563021 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
This bug has been verified as "pass" on latest Nightly build of Flame v2.2&master by the STR in Comment 0. Actual results: Screen reader users are able to operate all the lists, and the Playlist/Artist/Albums/Songs list items have proper semantics. See attachment: verified_master.3gp Reproduce rate: 0/10 Device: Flame v2.2 (Verified) Build ID 20150702162501 Gaia Revision 2d6cbec3a4004bb770ecbadbba83f86b95365e56 Gaia Date 2015-07-02 13:40:55 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b465f8d7254f Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150702.195016 Firmware Date Thu Jul 2 19:50:27 EDT 2015 Bootloader L1TC000118D0 Device: Flame master (Verified) Build ID 20150702160209 Gaia Revision 722028715a56a03f327e2e70f2c32dcb6d819d4c Gaia Date 2015-07-02 08:51:28 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/2f25351c5b05 Gecko Version 42.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150702.193535 Firmware Date Thu Jul 2 19:35:46 EDT 2015 Bootloader L1TC000118D0
Status: RESOLVED → VERIFIED
Attached video verified_master.3gp (deleted) —
Attached video verified_v2.2.3gp (obsolete) (deleted) —
QA Whiteboard: [MGSEI-Triage+]
Attachment #8629291 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: