Closed
Bug 1069818
Opened 10 years ago
Closed 10 years ago
Sometimes, in the waterfall, markers are not sorted properly
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox36 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox36 | --- | fixed |
People
(Reporter: paul, Unassigned)
References
Details
(Whiteboard: [fixed by 1070089])
Attachments
(1 file)
|
(deleted),
image/png
|
Details |
screenshot
For any markers in the timeline, any marker starting earlier than another marker should be displayed before the other marker.
But apparently, sometimes, it doesn't happen.
|
||
Comment 1•10 years ago
|
||
I guess the markers we receive aren't always consecutive, time-wise. That's okay, we can defer this sorting, but Paul, do you have an explanation for that?
|
Reporter | |
Comment 2•10 years ago
|
||
(In reply to Victor Porof [:vporof][:vp] from comment #1)
> I guess the markers we receive aren't always consecutive, time-wise. That's
> okay, we can defer this sorting, but Paul, do you have an explanation for
> that?
I don't. Markers are added, sorted and poped synchronously. Weird. Patrick?
Flags: needinfo?(pbrosset)
|
||
Comment 3•10 years ago
|
||
On irc we discussed it and the hypothesis is that this is bug 1070089
|
||
Comment 4•10 years ago
|
||
(In reply to Tom Tromey :tromey from comment #3)
> On irc we discussed it and the hypothesis is that this is bug 1070089
Yeah, this looks like it's the issue for sure. Each docShell has its own mProfileTimelineStartTime member which is set to the time the recording started for that docShell. So when we record nested iframes too, they're going to have their own start times.
Flags: needinfo?(pbrosset)
|
|
||
Comment 5•10 years ago
|
||
I think this was fixed when bug 1070089 was fixed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
|
||
Comment 6•10 years ago
|
||
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).
dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•