Closed
Bug 1070029
Opened 10 years ago
Closed 10 years ago
Fade last character on labels rather than use "..."
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: antlam, Assigned: lucasr)
References
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
prev_tabletui_vert_mock7.png
As per bug 1061508, let's make this change but can we control the amount of fading we do? Particularly, it seems fading more than 1-2 characters is a bit excessive. I'd like to call out we fade no more than that...
The advantage to fading vs. truncating with "..." is that it gives an extra character rather than using that to display a "..."
Flags: needinfo?(lucasr.at.mozilla)
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8494790 -
Flags: review?(michael.l.comella)
Flags: needinfo?(lucasr.at.mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8494790 [details] [diff] [review]
Use FadedTextView in TabStripItemView (r=mcomella)
Review of attachment 8494790 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry, not sure how I missed this one.
Attachment #8494790 -
Flags: review?(michael.l.comella) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
The previous push was empty :-/ Here's the real one:
https://hg.mozilla.org/integration/fx-team/rev/a1df0b99a0f0
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → lucasr.at.mozilla
https://hg.mozilla.org/mozilla-central/rev/b2d50b8f8b5a
https://hg.mozilla.org/mozilla-central/rev/a1df0b99a0f0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•