If I have a missed call I can long press on the call in the log and choose Call Information. That shows me all the numbers I have for the contact though, and there's no distinction that shows me which # they called me on. If I want to call them back on a land line or something I'm out of luck.

This seems like pretty broken UX. Could we get clarification from UX on the expected behavior?

Moving the question (comment 1) to Carrie who designed the new call information page.

Kyle: We do highlight the number that called you (or that you called) with a green color for the phone number. Maybe it's a problem with phone matching? Have you stored that contact without international prefixes?

Ok, I only see that (quite subtle) green text on outgoing calls. None of my incoming calls have them. I have country code prefixes on all of my contacts.

dbaron sees the same thing on his device. We do have the same carrier (T-Mobile).

I don't see it either, so I don't think it's carrier specific. Anthony - is it supposed to be highlighted in the call log, or in the call information page?

Just in the call information page. Doug: Could you look into this? We've had quite a few issues with prefixes in different situations. Depending on the context, we may need two matching algorithms: a loose one and a strict one.

PR: https://github.com/mozilla-b2g/gaia/pull/24861 The changes in a couple of spots are kind of wonky. In particular, the changes to dialer/mock_contacts.js were needed because SimplePhoneMatcher gives us a match index, which was always matching the first (and only) phone number on a contact. We can verify that this is needed by adding a garbage number to the forEach test array at call_info_test.js#L210. With `mNumTels = 1`, it passes, but without, it fails.

Oops, here it is with 8 lines of context.

Carrie, we were thinking of removing the feature in the Contacts app that highlights phone numbers when coming from the Dialer's "edit contact" button. This is a bit of a relic from before we had the call information page. Now that we have this page, it seems unnecessary. What do you think?

Hi Doug, Does that "coming from the Dialer's "edit contact" button" means by tapping the Contacts tab on the bottom of Phone APP and trigger edit mode over there? If so, then I'm fine with it. Thanks!

Carrie: The path we're thinking about removing is this one: 1) Call Log 2) Open a Call info page (notice the number is highlighted) 3) Open contact details On that contact details page, the number is also highlighted. That was necessary when we didn't have the call info page. Now it seems a bit redundant.

OK got it. Yes, I think that will be fine. Thanks!

PR: https://github.com/mozilla-b2g/gaia/pull/24861 Rebased, no changes to the code. Comment 14 is now incorrect as bug 1080771 has landed.

Comment on attachment 8509923 [details] [diff] [review] Highlight phone numbers on contacts buttons that are close matches of call log entries. Review of attachment 8509923 [details] [diff] [review]: ----------------------------------------------------------------- The tests are using a real object instead of a mock.

Addressed code review comments, updated PR. Sorry, I accidentally squashed my changes.