Closed Bug 1070149 Opened 10 years ago Closed 10 years ago

Add explicit file removals for channel-prefs.js, update-settings.ini, and precomplete files

Categories

(Firefox :: Installer, defect)

Product:
Firefox
Component:
Installer
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 35
Tracking Flags:
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 5 obsolete files)

patch - more files
(deleted), patch
spohl
: review+
Details | Diff | Splinter Review
These are excluded from the precomplete file and will need to be explicitly removed during app update for Mac v2 signing.
Status: NEW → ASSIGNED
Depends on: 1059567
Depends on: 1070811
Attached patch patch in progress (obsolete) (deleted) — — Splinter Review
A different approach may be needed depending on whether we want to fix bug 1070836.
Attached patch patch rev1 (obsolete) (deleted) — — Splinter Review
Pushed to oak https://hg.mozilla.org/projects/oak/rev/f4860a7b6a8f
Attachment #8492894 - Attachment is obsolete: true
Attachment #8492914 - Flags: review?(spohl.mozilla.bugs)
Attached patch patch rev2 (obsolete) (deleted) — — Splinter Review
Attachment #8492914 - Attachment is obsolete: true
Attachment #8492914 - Flags: review?(spohl.mozilla.bugs)
Attachment #8492977 - Flags: review?(spohl.mozilla.bugs)
Attached patch patch rev3 (obsolete) (deleted) — — Splinter Review
wow... did I ever get that wrong!
Attachment #8492977 - Attachment is obsolete: true
Attachment #8492977 - Flags: review?(spohl.mozilla.bugs)
Attachment #8492987 - Flags: review?(spohl.mozilla.bugs)
Attachment #8492987 - Flags: review?(spohl.mozilla.bugs) → review+
Attached patch patch - more files (obsolete) (deleted) — — Splinter Review
I'm going to hold off on requesting review until I've had a chance to verify there aren't more files that need to be removed.
Attachment #8492987 - Attachment is obsolete: true
Attached patch patch - more files (deleted) — — Splinter Review
Landed updated patch on oak https://hg.mozilla.org/projects/oak/rev/c5db0f1fc022
Attachment #8493151 - Attachment is obsolete: true
Attachment #8493196 - Flags: review?(spohl.mozilla.bugs)
Attachment #8493196 - Flags: review?(spohl.mozilla.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/5d6da7c4a822
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34: --- → fixed
status-firefox35: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: